TextScroller: Use finish_script properly #3294
Merged
+25
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypernoot
changed the title
johannes-el
approved these changes
Jul 5, 2025
Member
|
In theory, I think that code can be moved to its own method, since it's used in multiple places. |
Member
Author
|
Indeed, I will do that. |
Member
Author
|
I noticed that the fading time is slightly different when the textscroller is exited by Esc instead of letting it run out. I removed this feature, as I think that it's rather accidental. |
Hypernoot
force-pushed
the
textscroller
branch
from
18c3ed5 to
a63aebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3219
If the finish_script is not defined, the level is finished when the text runs out or Esc is pressed. Otherwise, the finish_script is run instead.