Initialize m_selection in initialization list (#3256)

tobbi · web-flow · commit f85675a3da7b · 2025-05-10T10:21:49.000+02:00
diff --git a/src/editor/layer_icon.cpp b/src/editor/layer_icon.cpp
@@ -29,10 +29,9 @@ LayerIcon::LayerIcon(LayerObject* layer) :
   ObjectIcon("", layer->get_icon_path()),
   m_layer(layer),
   m_layer_tilemap(dynamic_cast<TileMap*>(layer)),
-  m_selection()
+  m_selection(m_layer_tilemap ? 
+                Surface::from_file("images/engine/editor/selection.png") : nullptr)
 {
-  if (m_layer_tilemap)
-    m_selection = Surface::from_file("images/engine/editor/selection.png");
 }
 
 void

Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,9 @@ LayerIcon::LayerIcon(LayerObject* layer) :`
`29`	`29`	`ObjectIcon("", layer->get_icon_path()),`
`30`	`30`	`m_layer(layer),`
`31`	`31`	`m_layer_tilemap(dynamic_cast<TileMap*>(layer)),`
`32`		`- m_selection()`
	`32`	`+ m_selection(m_layer_tilemap ?`
	`33`	`+ Surface::from_file("images/engine/editor/selection.png") : nullptr)`
`33`	`34`	`{`
`34`		`- if (m_layer_tilemap)`
`35`		`- m_selection = Surface::from_file("images/engine/editor/selection.png");`
`36`	`35`	`}`
`37`	`36`
`38`	`37`	`void`