Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dawn/dusk times reversed? #40

Closed
atomicbird opened this issue May 3, 2023 · 3 comments · Fixed by #41
Closed

Dawn/dusk times reversed? #40

atomicbird opened this issue May 3, 2023 · 3 comments · Fixed by #41
Assignees
Labels
bug Something isn't working

Comments

@atomicbird
Copy link

atomicbird commented May 3, 2023

When testing SunKit, the dumpDateInfos function includes the following:

Civil dusk          -> Tuesday, May 2, 2023 at 5:31:09 AM Mountain Daylight Time
Civil Dawn           -> Tuesday, May 2, 2023 at 8:21:42 PM Mountain Daylight Time
Nautical Dusk     -> Tuesday, May 2, 2023 at 4:56:05 AM Mountain Daylight Time
Nautical Dawn      -> Tuesday, May 2, 2023 at 8:56:46 PM Mountain Daylight Time
Astronomical Dusk -> Tuesday, May 2, 2023 at 4:18:26 AM Mountain Daylight Time
Astronomical Dawn  -> Tuesday, May 2, 2023 at 9:34:25 PM Mountain Daylight Time

In each case, dawn is shown as being in the evening, while dusk is in the morning.

I thought at first that the dawn times were for tomorrow, i.e. the next time dawn arrived, but they all show the same date. Printing their UTC values shows the same issue, dusk occurs before dawn:

Civil dawn: 2023-05-03 02:21:42 +0000
Civil dusk: 2023-05-02 11:31:09 +0000

Nautical dawn: 2023-05-03 02:56:46 +0000
Nautical dusk: 2023-05-02 10:56:05 +0000

Astronomical dawn: 2023-05-03 03:34:25 +0000
Astronomical dusk: 2023-05-02 10:18:26 +0000

I don’t know if this means dawn and dusk times are reversed or if there’s some other problem.

My Package.resolved shows that I’m using tag 2.6.3, so I should be up to date.

@seldon1000 seldon1000 added the bug Something isn't working label May 3, 2023
@seldon1000
Copy link
Member

Hello. The solar events' names are indeed inverted: dawn happens in the morning while dusk happens in the evening. Thank you for reporting. A fix should come soon in the next release.

@davideilmito davideilmito linked a pull request May 3, 2023 that will close this issue
@davideilmito
Copy link
Collaborator

Hi @atomicbird, the fix shall be on main branch. If you liked the package leave a star ;).

@atomicbird
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants