Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency Converter API value #97

Open
marianomontano opened this issue Feb 19, 2022 · 2 comments
Open

Currency Converter API value #97

marianomontano opened this issue Feb 19, 2022 · 2 comments
Labels
Priority: Medium Needs to fixed sooner. Status: Confirmed Will surely be fixed or implemented

Comments

@marianomontano
Copy link

marianomontano commented Feb 19, 2022 •
edited
Loading

I'm trying to add a new currency (ARS - argentine peso) into the Currency Converter module and the API returns "buyer" value and it would be great if it returned "seller" value.
Example:
// 20220219193733
// https://free.currconv.com/api/v7/convert?q=USD_ARS&compact=ultra&apiKey=xxxxxxxxxxxxxxx
{
"USD_ARS": 106.793999
}
The following screenshot was taken from Argentina's National Bank
image

By the way, thanks for your work, I love this calculator!
@SubhadeepJasu
Copy link
Owner

Okay, I will add that in. As for seller value, I'll have to check the other endpoints of the api or may be even look or another api that provides that value.

@SubhadeepJasu SubhadeepJasu added Priority: Medium Needs to fixed sooner. Status: Confirmed Will surely be fixed or implemented labels Feb 20, 2022
@SubhadeepJasu
Copy link
Owner

Oh I just saw the pull request. Thank you very much.😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium Needs to fixed sooner. Status: Confirmed Will surely be fixed or implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SubhadeepJasu @marianomontano