calc_scaling operation override#1085
Closed
real-niacat wants to merge 1 commit intoSteamodded:mainfrom
Closed
Conversation
Collaborator
|
Is it ok that multiple jokers with that effect would just override each other? |
Collaborator
|
Because of #1014 maybe makes sense to make some kind of util function to apply effect of calc_scaling? |
Contributor
Author
|
i think its fine if multiple cards override each other like this, idk how you would cleanly implement it w/o having one take priority over another |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows cards in calc_scaling to provide an override operation (e.g. making all other scaling jokers scale multiplicitively)
sorry for no lsp defs i didnt see anything relating to the arguments of calc_scaling's return values
Additional Info: