You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In-principle, the estimator could be moved to xgboostlss itself and indexed in skpro, but there are a couple things that I would consider issues or design questions.
the unpleasant dependency set and the lack of soft dependency isolation in xgboostlss, which have already been mentioned here: update torch, optuna & scikitlearn install deps #77 - this restricts usability quite a bit, and prevents 3.12 compatibility afaik
there are a lot of distributions both in skpro and xgboostlss - they overlap but they are not identical (e.g., skpro does not have the zero-inflated ones, etc). A number of questions around those:
In your various packages the same code seems also to be copied around. This is a violation of the DRY principle across packages, and we should think about where to put the distributions.
by extension, it might be worth thinking about what your requirements are, and whether a merge - or partial merge - to skpro seems sensible. Obviously, it is not easy without some rearchitecting and design work.
the user interface of xgboostlss is also a bit hard to use - e.g., the user needs to configure a lot and execute a sequence of methods that is unexpected. Unlike xgboost, there is no simple train/predict workflow - this made xgboost very popular. In skpro, I have tried to smoothe out the interface, of course there is the open question how to do this, and what the best way for the lower level interfaces in xgboostls would be.
Hi @StatMixedML, I have now written an
sktime
interface toxgbootslss
.sktime/skpro#522
In-principle, the estimator could be moved to
xgboostlss
itself and indexed inskpro
, but there are a couple things that I would consider issues or design questions.xgboostlss
, which have already been mentioned here: update torch, optuna & scikitlearn install deps #77 - this restricts usability quite a bit, and prevents 3.12 compatibility afaikskpro
andxgboostlss
- they overlap but they are not identical (e.g.,skpro
does not have the zero-inflated ones, etc). A number of questions around those:skpro
seems sensible. Obviously, it is not easy without some rearchitecting and design work.xgboostlss
is also a bit hard to use - e.g., the user needs to configure a lot and execute a sequence of methods that is unexpected. Unlikexgboost
, there is no simple train/predict workflow - this madexgboost
very popular. Inskpro
, I have tried to smoothe out the interface, of course there is the open question how to do this, and what the best way for the lower level interfaces inxgboostls
would be.Happy to chat, e.g., on
dev-chat
on thesktime
discord https://discord.com/invite/54ACzaFsn7The text was updated successfully, but these errors were encountered: