Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: details marker shows next to hamburger menu on mobile #128

Closed
3 tasks done
troyciesco opened this issue Oct 1, 2024 · 3 comments · Fixed by #130
Closed
3 tasks done

🐛 Bug: details marker shows next to hamburger menu on mobile #128

troyciesco opened this issue Oct 1, 2024 · 3 comments · Fixed by #130
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛

Comments

@troyciesco
Copy link
Contributor

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

The little arrow for the details/summary elements in the header should be hidden, because the hamburger menu replaces it.

Actual

On mobile browsers (chromium and firefox, iOS) the details marker is showing next to the hamburger menu:
details-marker-showing

It doesn't happen on desktop browsers, even using the dev tools.

Additional Info

It's one style change and I had to fork the code to look at it anyway, so I'm happy to submit a PR!

I'm reasonably confident that there are no accessibility issues (keyboard functionality still worked) and that this works for both chromium and firefox, at least on iOS:

	summary::-webkit-details-marker {
		display: none;
	}
@troyciesco troyciesco added the type: bug Something isn't working :( 🐛 label Oct 1, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! 🙏 label Oct 1, 2024
@JoshuaKGoldberg
Copy link
Member

Aha! I could have sworn I'd seen this in the past on mobile Safari, and fixed it... but apparently not. Thanks for reporting @troyciesco; we'd love a PR if you have time!

@JoshuaKGoldberg
Copy link
Member

@all-contributors please add @troyciesco for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @troyciesco! 🎉

JoshuaKGoldberg pushed a commit that referenced this issue Oct 1, 2024
Adds @troyciesco as a contributor for bug.

This was requested by JoshuaKGoldberg [in this
comment](#128 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants