Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add grouping rules for other repos #312

Closed
tasomaniac opened this issue Dec 26, 2020 · 6 comments
Closed

Ability to add grouping rules for other repos #312

tasomaniac opened this issue Dec 26, 2020 · 6 comments

Comments

@tasomaniac
Copy link

Is your feature request related to a problem? Please describe.

This project has a really cool feature where you don't have to maintain multiple versions since a library group is known to use the same version for all of its artifacts. Good example is retrofit2. All of it's versions will be simply stored in version.retrofit2 and be shared.

Describe the solution you'd like

The same applies to some of group of artifacts too. refreshVersions can provide rules functionality to support this. And versions.properties will become easier to maintain.

@moritzruth
Copy link

Another example: Netty

@LouisCAD
Copy link
Member

LouisCAD commented Jan 3, 2021

This is already supported but not documented. You can see an example in the sample-kotlin sample.

FYI, we have been thinking of different approaches where this could partially be inferred, or where it could be defined from code, but both of these approaches seem tricky to implement.

@tasomaniac
Copy link
Author

Is it possible to link to the example? I couldn't see how it is done. I just checked. It seems like the following version is defined 2 times back to back
https://github.com/jmfayard/refreshVersions/blob/main/sample-kotlin/versions.properties#L84

@joharei
Copy link
Contributor

joharei commented Jan 25, 2021

Is it possible to link to the example? I couldn't see how it is done. I just checked. It seems like the following version is defined 2 times back to back
https://github.com/jmfayard/refreshVersions/blob/main/sample-kotlin/versions.properties#L84

@tasomaniac If you remove lines 84-86, the sample seems to work correctly, using the version from version.apache.poi. However, I'd expect the plugin to remove those duplicate lines by itself since they are covered by a shorter name. @LouisCAD Is this a bug, or is it intended?

@LouisCAD
Copy link
Member

@joharei Probably a bug, though in future versions, we might have a different behavior as we might stop auto-removing unused entries, just adding a warning/info comment instead.

@jmfayard
Copy link
Member

jmfayard commented Aug 8, 2021

I've explained how it works here:

#356 (comment)

@jmfayard jmfayard closed this as completed Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants