Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dokka version management in version.kotlin #211

Closed
DanySK opened this issue Aug 7, 2020 · 3 comments
Closed

Merge dokka version management in version.kotlin #211

DanySK opened this issue Aug 7, 2020 · 3 comments

Comments

@DanySK
Copy link
Contributor

DanySK commented Aug 7, 2020

refreshVersions comes in with a handy custom rule for kotlin, which produces a version.kotlin entry. Starting with Kotlin 1.4.0-rc, though, dokka artifacts are sharing the kotlin version as well, namely, one should manually write stuff like:

version.org.jetbrains.dokka..dokka-core=version.kotlin

version.org.jetbrains.dokka..dokka-gradle-plugin=version.kotlin

version.org.jetbrains.dokka..javadoc-plugin=version.kotlin

I was wondering if it'd be possible to perform the bound automatically. Also (but I think there is another issue opened about it), when running refreshVersions on a project configured as such, version.properties gets broken due to duplicated entries:

version.org.jetbrains.dokka..dokka-core=1.4.0-rc

version.org.jetbrains.dokka..dokka-core=version.kotlin

version.org.jetbrains.dokka..dokka-gradle-plugin=1.4.0-rc

version.org.jetbrains.dokka..dokka-gradle-plugin=version.kotlin

version.org.jetbrains.dokka..javadoc-plugin=1.4.0-rc

version.org.jetbrains.dokka..javadoc-plugin=version.kotlin

@jmfayard
Copy link
Member

@LouisCAD
Copy link
Member

LouisCAD commented Sep 14, 2022

@jmfayard I don't think so, it has nothing to do with versionFor. 🧐

Inferring matching version histories would still be interesting, though it's though because of the risk of false positives.

@jmfayard
Copy link
Member

jmfayard commented Sep 14, 2022

If versionFor is not an option, it could be done with a simpler api for rule
#580 (comment)

Then it's only a one liner

version.dokka=version.kotlin

I was wondering if it'd be possible to perform the bound automatically

Actually this is something I had in mind for #580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants