Fix a typo in workflowClientCallsInterceptor() method name introduced in temporalio#382

Spikhalskiy · Spikhalskiy · commit bbfd2d8d015d · 2021-03-25T01:10:19.000-04:00
diff --git a/temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowClientInterceptor.java b/temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowClientInterceptor.java
@@ -35,7 +35,7 @@ public interface WorkflowClientInterceptor {
    * @return decorated stub
    * @deprecated consider implementing all intercepting functionality using {@link
    *     WorkflowClientCallsInterceptor} that is produced in {@link
-   *     #workflowClientClassInterceptor}. This method has to stay temporary because
+   *     #workflowClientCallsInterceptor}. This method has to stay temporary because
    *     TimeLockingInterceptor has to intercept top level {@link WorkflowStub} methods.
    */
   @Deprecated
@@ -49,7 +49,7 @@ WorkflowStub newUntypedWorkflowStub(
    * @return decorated stub
    * @deprecated consider implementing all intercepting functionality using {@link
    *     WorkflowClientCallsInterceptor} that is produced in {@link
-   *     #workflowClientClassInterceptor}. This method has to stay temporary because
+   *     #workflowClientCallsInterceptor}. This method has to stay temporary because
    *     TimeLockingInterceptor has to intercept top level {@link WorkflowStub} methods.
    */
   @Deprecated
@@ -59,11 +59,11 @@ WorkflowStub newUntypedWorkflowStub(
   ActivityCompletionClient newActivityCompletionClient(ActivityCompletionClient next);
 
   /**
-   * Called once during creation of WorkflowClient to create a chain of Client Interceptors
+   * Called once during creation of WorkflowClient to create a chain of Client Workflow Interceptors
    *
    * @param next next workflow client interceptor in the chain of interceptors
    * @return new interceptor that should decorate calls to {@code next}
    */
-  WorkflowClientCallsInterceptor workflowClientClassInterceptor(
+  WorkflowClientCallsInterceptor workflowClientCallsInterceptor(
       WorkflowClientCallsInterceptor next);
 }
diff --git a/temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowClientInterceptorBase.java b/temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowClientInterceptorBase.java
@@ -48,7 +48,7 @@ public ActivityCompletionClient newActivityCompletionClient(ActivityCompletionCl
   }
 
   @Override
-  public WorkflowClientCallsInterceptor workflowClientClassInterceptor(
+  public WorkflowClientCallsInterceptor workflowClientCallsInterceptor(
       WorkflowClientCallsInterceptor next) {
     return next;
   }
diff --git a/temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowClientInternal.java b/temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowClientInternal.java
@@ -101,7 +101,7 @@ private WorkflowClientCallsInterceptor initializeClientInvoker() {
         new RootWorkflowClientInvoker(genericClient, options, metricsScope);
     for (WorkflowClientInterceptor clientInterceptor : interceptors) {
       workflowClientInvoker =
-          clientInterceptor.workflowClientClassInterceptor(workflowClientInvoker);
+          clientInterceptor.workflowClientCallsInterceptor(workflowClientInvoker);
     }
     return workflowClientInvoker;
   }
diff --git a/temporal-sdk/src/test/java/io/temporal/workflow/ChildWorkflowRetryTest.java b/temporal-sdk/src/test/java/io/temporal/workflow/ChildWorkflowRetryTest.java
@@ -67,7 +67,7 @@ public class ChildWorkflowRetryTest {
                   .setInterceptors(
                       new WorkflowClientInterceptorBase() {
                         @Override
-                        public WorkflowClientCallsInterceptor workflowClientClassInterceptor(
+                        public WorkflowClientCallsInterceptor workflowClientCallsInterceptor(
                             WorkflowClientCallsInterceptor next) {
                           return new WorkflowClientCallsInterceptorBase(next) {
                             @Override
diff --git a/temporal-sdk/src/test/java/io/temporal/workflow/WorkflowTest.java b/temporal-sdk/src/test/java/io/temporal/workflow/WorkflowTest.java
@@ -142,7 +142,7 @@ public void setUp() {
             .setInterceptors(
                 new WorkflowClientInterceptorBase() {
                   @Override
-                  public WorkflowClientCallsInterceptor workflowClientClassInterceptor(
+                  public WorkflowClientCallsInterceptor workflowClientCallsInterceptor(
                       WorkflowClientCallsInterceptor next) {
                     return new WorkflowClientCallsInterceptorBase(next) {
                       @Override

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public ActivityCompletionClient newActivityCompletionClient(ActivityCompletionCl`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`@Override`
`51`		`- public WorkflowClientCallsInterceptor workflowClientClassInterceptor(`
	`51`	`+ public WorkflowClientCallsInterceptor workflowClientCallsInterceptor(`
`52`	`52`	`WorkflowClientCallsInterceptor next) {`
`53`	`53`	`return next;`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ private WorkflowClientCallsInterceptor initializeClientInvoker() {`
`101`	`101`	`new RootWorkflowClientInvoker(genericClient, options, metricsScope);`
`102`	`102`	`for (WorkflowClientInterceptor clientInterceptor : interceptors) {`
`103`	`103`	`workflowClientInvoker =`
`104`		`- clientInterceptor.workflowClientClassInterceptor(workflowClientInvoker);`
	`104`	`+ clientInterceptor.workflowClientCallsInterceptor(workflowClientInvoker);`
`105`	`105`	`}`
`106`	`106`	`return workflowClientInvoker;`
`107`	`107`	`}`