Updated Codacy static analysis to latest version on GitHub Actions

[sphereCrypt.ini]: Added crypt key for classic client 7.0.98 and enhanced client 4.0.98

Author: coruja747

.github/workflows/codacy-analysis.yml

@@ -15,10 +15,10 @@ name: Codacy Security Scan
 
 on:
   push:
-    branches: [ master ]
+    branches: [ "master" ]
   pull_request:
     # The branches below must be a subset of the branches above
-    branches: [ master ]
+    branches: [ "master" ]
 
 permissions:
   contents: read
@@ -28,12 +28,13 @@ jobs:
     permissions:
       contents: read # for actions/checkout to fetch code
       security-events: write # for github/codeql-action/upload-sarif to upload SARIF results
+      actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status
     name: Codacy Security Scan
     runs-on: ubuntu-latest
     steps:
       # Checkout the repository to the GitHub Actions runner
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       # Execute Codacy Analysis CLI and generate a SARIF output with the security issues identified during the analysis
       - name: Run Codacy Analysis CLI
@@ -53,6 +54,6 @@ jobs:
 
       # Upload the SARIF file generated in the previous step
       - name: Upload SARIF results file
-        uses: github/codeql-action/upload-sarif@v1
+        uses: github/codeql-action/upload-sarif@v2
         with:
           sarif_file: results.sarif

changelog.txt

@@ -1862,4 +1862,7 @@ Fixed: Server crash when call intrinsic functions <eval ISNUMBER()> / <floatval
 [sphereCrypt.ini]: Added crypt key for classic client 7.0.97 and enhanced client 4.0.97
 
 21-10-2022, Coruja
-Changed: Updated internal Zlib libs v1.2.11 to v1.2.13.
+Changed: Updated internal Zlib libs v1.2.11 to v1.2.13.
+
+28-01-2023, Coruja
+[sphereCrypt.ini]: Added crypt key for classic client 7.0.98 and enhanced client 4.0.98

src/graysvr/CClient.h

@@ -296,7 +296,8 @@ enum BUFF_ICONS
 	BI_POTIONOFGLORIOUSFORTUNE,
 	BI_MYSTICALPOLYMORPHTOTEM,
 	BI_DISCORDANCEDEBUFF,
-	BI_CHALICEOFPILFERINGPROTECTION
+	BI_CHALICEOFPILFERINGPROTECTION,
+	BI_BATTLELUST
 };
 
 struct CSectorEnviron		// When these change it is an CTRIG_EnvironChange

src/graysvr/SphereSvr.rc

@@ -43,7 +43,7 @@ BEGIN
 			VALUE "FileDescription",	"SphereServer " SPHERE_VER_STR
 			VALUE "FileVersion",		SPHERE_VER_STR_FULL
 			VALUE "InternalName",		"SphereSvr"
-			VALUE "LegalCopyright",		"Copyright 1997-2022 by SphereServer development team"
+			VALUE "LegalCopyright",		"Copyright 1997-2023 by SphereServer development team"
 			VALUE "OriginalFilename",	"SphereSvr.exe"
 			VALUE "ProductName",		"SphereServer"
 			VALUE "ProductVersion",		SPHERE_VER_STR_FULL
@@ -115,7 +115,7 @@ BEGIN
 	LTEXT		"Version", IDC_ABOUT_VERSION, 10, 8, 200, 8
 	CTEXT		"Website", IDC_ABOUT_WEBSITE, 220, 8, 90, 8
 	LTEXT		"Compiler", IDC_ABOUT_COMPILER, 10, 16, 200, 8
-	LTEXT		"Copyright (C) 1997-2022 SphereServer development team", 3, 10, 24, 200, 8
+	LTEXT		"Copyright (C) 1997-2023 SphereServer development team", 3, 10, 24, 200, 8
 	CTEXT		"___________________________________________________________________________", 4, 0, 32, 320, 8
 	LTEXT		"This software makes use of:", 5, 10, 46, 100, 8
 	LTEXT		"libev library (v4.33)\nCopyright (C) 2007-2020 Marc Alexander Lehmann", 6, 15, 62, 290, 16

src/sphereCrypt.ini

@@ -1,10 +1,10 @@
 //****************************************************************************
-// Copyright 2022 SphereServer development team
+// Copyright 2023 SphereServer development team
 // Licensed under the Apache License, Version 2.0 (the "License").
 // You may not use this file except in compliance with the License.
 // You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
 //****************************************************************************
-// FILE LAST UPDATED: Friday, Sept 30, 2022
+// FILE LAST UPDATED: Saturday, Jan 28, 2023
 
 // WARNING: Modifing this file, without knowing what you are doing, can make Sphere behave incorrectly.
 
@@ -22,6 +22,7 @@ ENC_TFISH  3 // Twofish
 
 [SPHERECRYPT]
 //Classic Clients
+7009800 03AA8ABDD 0A9AB227F ENC_TFISH // 7.0.98
 7009700 03AE221ED 0A9F47E7F ENC_TFISH // 7.0.97
 7009600 03ADBA3FD 0A9E1527F ENC_TFISH // 7.0.96
 7009500 03B1D220D 0A915BE7F ENC_TFISH // 7.0.95
@@ -179,6 +180,7 @@ ENC_TFISH  3 // Twofish
 2000000 02D13A5FD 0A39D527F ENC_BFISH // 2.0.0
 
 //Enhanced Clients
+067900980 018A8ABDD 0B8AB227F ENC_TFISH // 4.0.98
 067900970 018E221ED 0B8F47E7F ENC_TFISH // 4.0.97
 067900960 018DBA3FD 0B8E1527F ENC_TFISH // 4.0.96
 067900950 0191D220D 0B815BE7F ENC_TFISH // 4.0.95