Skip to content

Commit 828c454

Browse files
committed
Adding unit test to verify the host header fix
1 parent d094c01 commit 828c454

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

ds3-sdk/src/test/java/com/spectralogic/ds3client/ConnectionFixture.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,12 @@ public static ConnectionDetails getConnection() {
2727
public static ConnectionDetails getConnection(final int port) {
2828
return ConnectionDetailsImpl.builder("localhost:" + port, new Credentials("id", "key")).build();
2929
}
30+
31+
public static ConnectionDetails getHttpConnection() {
32+
return getHttpConnection(8080);
33+
}
34+
35+
public static ConnectionDetails getHttpConnection(final int port) {
36+
return ConnectionDetailsImpl.builder("http://localhost:" + port, new Credentials("id", "key")).build();
37+
}
3038
}

ds3-sdk/src/test/java/com/spectralogic/ds3client/utils/NetUtils_Test.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,12 @@ public void getHttpDefaultPort() throws MalformedURLException {
167167
assertTrue(port == 80);
168168
}
169169

170+
@Test
171+
public void buildHostFieldWithHttp() {
172+
final String result = NetUtils.buildHostField(ConnectionFixture.getHttpConnection());
173+
assertThat(result, is("localhost:8080"));
174+
}
175+
170176
@Test
171177
public void buildHost() throws MalformedURLException {
172178
final ConnectionDetails details = new ConnectionDetails() {

0 commit comments

Comments
 (0)