Skip to content

Commit 7b0a5f5

Browse files
committed
Removing unused host param from method.
1 parent 5422b9b commit 7b0a5f5

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

ds3-sdk/src/main/java/com/spectralogic/ds3client/NetworkClientImpl.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,10 @@ public NetworkClientImpl(final ConnectionDetails connectionDetails) {
8585
try {
8686
this.connectionDetails = connectionDetails;
8787
this.host = buildHost(connectionDetails);
88-
this.client = createDefaultClient(connectionDetails, host);
88+
this.client = createDefaultClient(connectionDetails);
8989
} catch (final MalformedURLException e) {
90+
// TODO In 3.0 we should remove this try catch and expose the exception so that
91+
// we do not create a client that has a bad host url
9092
throw new RuntimeException(e);
9193
}
9294
}
@@ -105,7 +107,7 @@ public NetworkClientImpl(final ConnectionDetails connectionDetails, final Closea
105107
}
106108

107109

108-
private static CloseableHttpClient createDefaultClient(final ConnectionDetails connectionDetails, final HttpHost host) {
110+
private static CloseableHttpClient createDefaultClient(final ConnectionDetails connectionDetails) {
109111
final PoolingHttpClientConnectionManager connectionManager = new PoolingHttpClientConnectionManager();
110112
connectionManager.setDefaultMaxPerRoute(MAX_CONNECTION_PER_ROUTE);
111113
connectionManager.setMaxTotal(MAX_CONNECTION_TOTAL);

0 commit comments

Comments
 (0)