Skip to content

Commit f74a1e5

Browse files
committed
linkedin#52: Adding test SKIP_CYCLE constant
1 parent 3983438 commit f74a1e5

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

test/headless/specs/utilities.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212

1313
import constants from './../../constants.js';
1414

15-
const { time: { RAF_THRESHOLD }, ITEM_TO_OBSERVE } = constants;
15+
const { time: { RAF_THRESHOLD }, ITEM_TO_OBSERVE, SKIP_CYCLE } = constants;
1616

1717
testModule('elementSatisfiesRatio', class extends TestClass {
1818
['@test passes true into callback when ratio satisfied']() {
@@ -79,11 +79,11 @@ testModule('Eventing', class extends TestClass {
7979
});
8080
})
8181
.scrollTo(10)
82-
.wait(RAF_THRESHOLD * 3)
82+
.wait(RAF_THRESHOLD * SKIP_CYCLE)
8383
.scrollTo(20)
84-
.wait(RAF_THRESHOLD * 3)
84+
.wait(RAF_THRESHOLD * SKIP_CYCLE)
8585
.getExecution()
86-
.wait(RAF_THRESHOLD)
86+
.wait(RAF_THRESHOLD * SKIP_CYCLE)
8787
.evaluate(function() {
8888
return window.STATE.scrollEvents;
8989
}).then(function(result) {

test/headless/specs/watcher/visible-event.spec.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212

1313
import constants from './../../../constants.js';
1414

15-
const { time: { RAF_THRESHOLD }, ITEM_TO_OBSERVE } = constants;
15+
const { time: { RAF_THRESHOLD }, ITEM_TO_OBSERVE, SKIP_CYCLE } = constants;
1616

1717
testModule('Visible event', class extends WatcherTestClass {
1818
['@test should not fire if item is exposed but not visible']() {
@@ -36,6 +36,7 @@ testModule('Visible event', class extends WatcherTestClass {
3636
.scrollTo(300)
3737
.wait(RAF_THRESHOLD * 5)
3838
.scrollTo(250)
39+
.wait(RAF_THRESHOLD * SKIP_CYCLE)
3940
.assertOnce(ITEM_TO_OBSERVE, 'visible')
4041
.done();
4142
}
@@ -50,7 +51,7 @@ testModule('Visible event', class extends WatcherTestClass {
5051
.scrollTo(10)
5152
.wait(RAF_THRESHOLD * 5)
5253
.scrollTo(200)
53-
.wait(RAF_THRESHOLD)
54+
.wait(RAF_THRESHOLD * SKIP_CYCLE)
5455
.assertEvent(ITEM_TO_OBSERVE, 'visible', 2)
5556
.done();
5657
}

0 commit comments

Comments
 (0)