Skip to content

Commit 9d54d96

Browse files
committed
linkedin#52 : Modified wait time since we are skipping few rFA cycles. So test are breaking. Still need to fix the large time dependency.
1 parent d9bc1f0 commit 9d54d96

6 files changed

+14
-14
lines changed

test/constants.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const constants = {
22
time: {
33
IMPRESSION_THRESHOLD : 100,
4-
RAF_THRESHOLD : 16,
4+
RAF_THRESHOLD : 22,
55
SMALL: 5
66
},
77
ITEM_TO_OBSERVE: 5

test/headless/specs/intersection-observer.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ testModule('IntersectionObserver', class extends TestClass {
2424
});
2525
observer.observe(target);
2626
})
27-
.wait(50)
27+
.wait(100)
2828
.getExecution()
2929
.evaluate(function() {
3030
return window.STATE.impressions;
@@ -44,7 +44,7 @@ testModule('IntersectionObserver', class extends TestClass {
4444
});
4545
observer.observe(target);
4646
})
47-
.wait(50)
47+
.wait(100)
4848
.getExecution()
4949
.evaluate(function() {
5050
return window.STATE.impressions;
@@ -154,7 +154,7 @@ testModule('IntersectionObserver', class extends TestClass {
154154
});
155155
window.observer.observe(window.target);
156156
})
157-
.wait(50)
157+
.wait(100)
158158
.evaluate(function() {
159159
window.observer.unobserve(window.target);
160160
})
@@ -184,7 +184,7 @@ testModule('IntersectionObserver', class extends TestClass {
184184
window.observer.observe(target2);
185185
window.observer.observe(target3);
186186
})
187-
.wait(50)
187+
.wait(100)
188188
.evaluate(function() {
189189
window.observer.disconnect();
190190
})
@@ -214,7 +214,7 @@ testModule('IntersectionObserver', class extends TestClass {
214214
window.observer.observe(target2);
215215
window.observer.observe(target3);
216216
})
217-
.wait(50)
217+
.wait(100)
218218
.evaluate(function() {
219219
window.observer.disconnect();
220220
})

test/headless/specs/spaniel-observer.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ testModule('SpanielObserver', class extends SpanielObserverTestClass {
5050
}
5151
['@test observing a visible element should fire after threshold time has passed']() {
5252
return this.setupTest()
53-
.wait(250)
53+
.wait(300)
5454
.getExecution()
5555
.evaluate(function() {
5656
return window.STATE.impressions;

test/headless/specs/watcher/exposed-event.spec.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,13 @@ testModule('Watcher Exposed Event', class extends WatcherTestClass {
4040
['@test should fire twice if moved in, out, and then back in viewport']() {
4141
return this.context.scrollTo(100)
4242
.scrollTo(140)
43-
.wait(RAF_THRESHOLD)
43+
.wait(RAF_THRESHOLD * 2)
4444
.scrollTo(120)
45-
.wait(RAF_THRESHOLD)
45+
.wait(RAF_THRESHOLD * 2)
4646
.scrollTo(0)
47-
.wait(RAF_THRESHOLD)
47+
.wait(RAF_THRESHOLD * 2)
4848
.scrollTo(50)
49-
.wait(RAF_THRESHOLD)
49+
.wait(RAF_THRESHOLD * 2)
5050
.assertEvent(ITEM_TO_OBSERVE, 'exposed', 2)
5151
.done();
5252
}

test/headless/specs/watcher/impression-complete-event.spec.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ testModule('Impression Complete event', class extends WatcherTestClass {
4747
return this.context.scrollTo(200)
4848
.wait(IMPRESSION_THRESHOLD + RAF_THRESHOLD * 4)
4949
.scrollTo(0)
50+
.wait(RAF_THRESHOLD * 3)
5051
.assertOnce(ITEM_TO_OBSERVE, 'impression-complete')
5152
.done();
5253
}
@@ -64,7 +65,7 @@ testModule('Impression Complete event', class extends WatcherTestClass {
6465
return this.context.scrollTo(150)
6566
.wait(IMPRESSION_THRESHOLD * 5)
6667
.scrollTo(0)
67-
.wait(RAF_THRESHOLD)
68+
.wait(RAF_THRESHOLD * 3)
6869
.assert(function(e) {
6970
return e.meta.duration >= 495 && e.meta.duration <= 545 && e.id === 5 && e.e === 'impression-complete';
7071
}, 1)

test/headless/specs/watcher/impression-event.spec.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ testModule('Impression event', class extends WatcherTestClass {
3434
return this.context.scrollTo(150)
3535
.wait(RAF_THRESHOLD)
3636
.scrollTo(250)
37-
.wait(RAF_THRESHOLD)
3837
.scrollTo(0)
3938
.assertNever(ITEM_TO_OBSERVE, 'impressed').done();
4039
}
@@ -66,7 +65,7 @@ testModule('Impression event', class extends WatcherTestClass {
6665
.wait(RAF_THRESHOLD)
6766
.assertNever(ITEM_TO_OBSERVE, 'impressed')
6867
.scrollTo(200)
69-
.wait(IMPRESSION_THRESHOLD + RAF_THRESHOLD)
68+
.wait(IMPRESSION_THRESHOLD + RAF_THRESHOLD * 2)
7069
.assertOnce(ITEM_TO_OBSERVE, 'impressed')
7170
.done();
7271
}

0 commit comments

Comments
 (0)