Handle non-200 status codes with JSON payload in GitHub API responses#80
Open
zonia3000 wants to merge 1 commit intoSpagett1:masterfrom
Open
Handle non-200 status codes with JSON payload in GitHub API responses#80zonia3000 wants to merge 1 commit intoSpagett1:masterfrom
zonia3000 wants to merge 1 commit intoSpagett1:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered the following error on application startup:
Debugging, I discovered that it was caused by the URL https://api.github.com/repos/Ralim/IronOS/releases replying as follow:
{ "message": "API rate limit exceeded for XX.XX.XX.XX. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)", "documentation_url": "https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting" }The code checks for invalid JSON but not for valid JSON with status code different than 200, as this case. I added a check for the status code too.