Skip to content

Commit 43c788f

Browse files
authored
Fix start.sh script for zip packaging. (#101)
* [#100] Fix where javadoc and source jars get packaged * [#100] bump release version to 2.0.1 * [#100] fix Dockerfile * tmp commit until a release package is uploaded * [#100] Include CHANGELOG, README, and LICENSE in package * [#100] Dont include dependencies twice in package * update CHANGELOG
1 parent 242e3a1 commit 43c788f

File tree

7 files changed

+43
-25
lines changed

7 files changed

+43
-25
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
The format is based on [Keep a Changelog](http://keepachangelog.com/)
33
and this project adheres to [Semantic Versioning](http://semver.org/).
44

5+
## 2.0.1 (10/02/2018)
6+
- [Issue#100](https://github.com/SourceLabOrg/kafka-webview/issues/100) Fix start.sh script
7+
- Dependency JARs were accidentally being included twice in release packages.
8+
59
## 2.0.0 (09/24/2018)
610

711
- Added new Stream consumer management page at /configuration/stream

Dockerfile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ FROM openjdk:8-jre-alpine
55
MAINTAINER SourceLab.org <[email protected]>
66

77
## Define what version of Kafka Webview to build the image using.
8-
ENV WEBVIEW_VER="2.0.0" \
9-
WEBVIEW_SHA1="f94015afdb0043a350a590b163f1fa79b5026aad" \
8+
ENV WEBVIEW_VER="2.0.1" \
9+
WEBVIEW_SHA1="TBD" \
1010
WEBVIEW_HOME="/app"
1111

1212
# Create app and data directories
@@ -26,8 +26,7 @@ RUN echo "${WEBVIEW_SHA1} /tmp/kafka-webview-ui-bin.zip" | sha1sum -c - && \
2626
unzip -d ${WEBVIEW_HOME} /tmp/kafka-webview-ui-bin.zip && \
2727
mv ${WEBVIEW_HOME}/kafka-webview-ui-${WEBVIEW_VER}/* ${WEBVIEW_HOME} && \
2828
rm -rf ${WEBVIEW_HOME}/kafka-webview-ui-${WEBVIEW_VER}/ && \
29-
rm -f ${WEBVIEW_HOME}/kafka-webview-ui-${WEBVIEW_VER}-sources.jar && \
30-
rm -f ${WEBVIEW_HOME}/kafka-webview-ui-${WEBVIEW_VER}-javadoc.jar && \
29+
rm -rf ${WEBVIEW_HOME}/src && \
3130
rm -f /tmp/kafka-webview-ui-bin.zip
3231

3332
# Create volume to persist data

dev-cluster/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
<parent>
66
<artifactId>kafka-webview</artifactId>
77
<groupId>org.sourcelab</groupId>
8-
<version>2.0.0</version>
8+
<version>2.0.1</version>
99
</parent>
1010
<modelVersion>4.0.0</modelVersion>
1111

1212
<artifactId>dev-cluster</artifactId>
13-
<version>2.0.0</version>
13+
<version>2.0.1</version>
1414

1515
<!-- Require Maven 3.3.9 -->
1616
<prerequisites>

kafka-webview-plugin/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<groupId>org.sourcelab</groupId>
77
<artifactId>kafka-webview</artifactId>
8-
<version>2.0.0</version>
8+
<version>2.0.1</version>
99
</parent>
1010
<modelVersion>4.0.0</modelVersion>
1111
<artifactId>kafka-webview-plugin</artifactId>

kafka-webview-ui/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
<parent>
66
<artifactId>kafka-webview</artifactId>
77
<groupId>org.sourcelab</groupId>
8-
<version>2.0.0</version>
8+
<version>2.0.1</version>
99
</parent>
1010
<modelVersion>4.0.0</modelVersion>
1111
<artifactId>kafka-webview-ui</artifactId>
12-
<version>2.0.0</version>
12+
<version>2.0.1</version>
1313

1414
<!-- Module Description and Ownership -->
1515
<name>Kafka WebView UI</name>

kafka-webview-ui/src/assembly/assembly.xml

Lines changed: 30 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,32 +4,47 @@
44
<format>zip</format>
55
</formats>
66

7-
<!-- Adds the dependencies of our application to the lib directory -->
8-
<dependencySets>
9-
<dependencySet>
10-
<useProjectArtifact>false</useProjectArtifact>
11-
<outputDirectory>lib</outputDirectory>
12-
<unpack>false</unpack>
13-
</dependencySet>
14-
</dependencySets>
15-
167
<fileSets>
8+
<!-- Include startup scripts -->
179
<fileSet>
18-
<directory>${basedir}/src/assembly/distribution/</directory>
10+
<directory>${project.basedir}/src/assembly/distribution/</directory>
1911
<outputDirectory></outputDirectory>
2012
<includes>
2113
<include>*</include>
2214
</includes>
2315
</fileSet>
24-
<!--
25-
Adds the jar file of our example application to the root directory
26-
of the created zip package.
27-
-->
16+
17+
<!-- Include Changelog, Readme, and License from top level project directory -->
18+
<fileSet>
19+
<directory>${project.basedir}/../</directory>
20+
<outputDirectory></outputDirectory>
21+
<includes>
22+
<include>CHANGELOG.md</include>
23+
<include>README.md</include>
24+
<include>LICENSE.txt</include>
25+
</includes>
26+
</fileSet>
27+
28+
<!-- Put the main JAR at the top level -->
2829
<fileSet>
2930
<directory>${project.build.directory}</directory>
3031
<outputDirectory></outputDirectory>
3132
<includes>
32-
<include>*.jar</include>
33+
<include>kafka-webview-ui-${project.version}.jar</include>
34+
</includes>
35+
<excludes>
36+
<exclude>kafka-webview-ui-*-sources.jar</exclude>
37+
<exclude>kafka-webview-ui-*-javadoc.jar</exclude>
38+
</excludes>
39+
</fileSet>
40+
41+
<!-- Put doc and source JARs under src/ -->
42+
<fileSet>
43+
<directory>${project.build.directory}</directory>
44+
<outputDirectory>src/</outputDirectory>
45+
<includes>
46+
<include>kafka-webview-ui-${project.version}-sources.jar</include>
47+
<include>kafka-webview-ui-${project.version}-javadoc.jar</include>
3348
</includes>
3449
</fileSet>
3550
</fileSets>

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<groupId>org.sourcelab</groupId>
88
<artifactId>kafka-webview</artifactId>
99
<packaging>pom</packaging>
10-
<version>2.0.0</version>
10+
<version>2.0.1</version>
1111

1212
<!-- Define submodules -->
1313
<modules>

0 commit comments

Comments
 (0)