Skip to content

Commit 11af57f

Browse files
authored
Update start.sh script, get ready for a release (#69)
1 parent cbf949c commit 11af57f

File tree

4 files changed

+23
-3
lines changed

4 files changed

+23
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
66
- Update NPM dependencies for [CVE-2017-18214](https://nvd.nist.gov/vuln/detail/CVE-2017-18214).
77
- Update [Kafka-JUnit](https://github.com/salesforce/kafka-junit) dependency to [Kafka-JUnit4](https://github.com/salesforce/kafka-junit/tree/master/kafka-junit4).
88
- Update SpringBoot dependency from 1.5.10 to 1.5.13.
9+
- Update start.sh script to allow setting JVM Heap options.
910

1011
## 1.0.3 (02/11/2018)
1112
- Fix 500 error unable to find templates when running under windows.

README.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,17 @@ To get up and going quickly, the [Kafka-WebView-Example](https://github.com/Sour
148148
This Maven based example project is configured with all of the correct dependencies and has a few example
149149
implementations.
150150

151+
# Releasing
152+
Steps for performing a release:
153+
154+
- Update release version: mvn versions:set -DnewVersion=X.Y.Z
155+
- Validate and then commit version: mvn versions:commit
156+
- Update CHANGELOG and README files.
157+
- Merge to master.
158+
- Deploy to Maven Central: mvn clean deploy -P release-kafka-webview
159+
- Create release on Github project.
160+
- Build new Docker images (TODO define steps)
161+
151162
# Changelog
152163

153164
The format is based on [Keep a Changelog](http://keepachangelog.com/)

kafka-webview-ui/src/assembly/distribution/start.sh

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,19 @@ CWD=`pwd`
55
## Change to local directory
66
cd "${0%/*}"
77

8+
# Define empty options as defaults if none set
9+
if [[ -z "$HEAP_OPTS" ]]; then
10+
export HEAP_OPTS=""
11+
fi
12+
if [[ -z "$LOG_OPTS" ]]; then
13+
export LOG_OPTS=""
14+
fi
15+
816
## Define configuration
917
export SPRING_CONFIG_LOCATION=classpath:/config/base.yml,config.yml
1018

1119
## launch webapp
12-
java -jar kafka-webview-ui-*.jar
20+
java -jar kafka-webview-ui-*.jar $HEAP_OPTS $LOG_OPTS
1321

1422
## Change back to previous directory
1523
cd $CWD

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@
171171
<!-- release profile for deploying -->
172172
<profiles>
173173
<profile>
174-
<id>release</id>
174+
<id>release-kafka-webview</id>
175175
<build>
176176
<plugins>
177177
<!-- Build Sources Jar -->
@@ -215,7 +215,7 @@
215215
<goal>sign</goal>
216216
</goals>
217217
<configuration>
218-
<keyname>SourceLab.org</keyname>
218+
<keyname>SourceLab.org</keyname>
219219
</configuration>
220220
</execution>
221221
</executions>

0 commit comments

Comments
 (0)