Bugfix in _unsubscribe()

mgeier · mgeier · commit 2213c36b2fd9 · 2019-01-21T20:17:46.000+01:00
diff --git a/src/controller.h b/src/controller.h
@@ -285,7 +285,11 @@ class Controller : public api::Publisher
     {
       assert(subscriber);
       auto& list = std::get<Subscribers<Events>>(_subscribers);
-      std::remove(list.begin(), list.end(), subscriber);
+      auto iter = std::find(list.begin(), list.end(), subscriber);
+      if (iter != list.end())
+      {
+        list.erase(iter);
+      }
     }
 
     template<typename PTMF, typename... Args>

Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,11 @@ class Controller : public api::Publisher`
`285`	`285`	`{`
`286`	`286`	`assert(subscriber);`
`287`	`287`	`auto& list = std::get<Subscribers<Events>>(_subscribers);`
`288`		`- std::remove(list.begin(), list.end(), subscriber);`
	`288`	`+ auto iter = std::find(list.begin(), list.end(), subscriber);`
	`289`	`+ if (iter != list.end())`
	`290`	`+ {`
	`291`	`+ list.erase(iter);`
	`292`	`+ }`
`289`	`293`	`}`
`290`	`294`
`291`	`295`	`template<typename PTMF, typename... Args>`