chore: fix clippy errors and bump version to 0.6.0

- Remove unused imports and re-exports across constraint, eval modules
- Rename eval/eval.rs to eval/evaluator.rs to fix module inception warning
- Add #[allow(clippy::too_many_arguments)] to factory functions
- Implement std::ops traits (Not, Add, Sub, Mul, Div, Neg) for Expr
- Fix explicit auto-deref in manager.rs
- Add #[allow(deprecated)] for pyo3 API deprecations
- Update PyObject to Py<PyAny> for pyo3 0.27 compatibility
- Fix redundant local variable in solve/tests.rs
- Add rlib crate-type to solverforge-py for cross-platform builds
- Bump all crate versions from 0.5.1 to 0.6.0

Author: blackopsrepl

.github/workflows/ci.yml

@@ -22,6 +22,11 @@ jobs:
         with:
           submodules: true
 
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+
       - name: Install Rust
         run: |
           curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable
@@ -58,6 +63,11 @@ jobs:
         with:
           submodules: true
 
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+
       - name: Install Rust
         run: |
           curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable

Cargo.lock

@@ -13,7 +13,7 @@ members = [
 ]
 
 [workspace.package]
-version = "0.5.1"
+version = "0.6.0"
 edition = "2021"
 license = "Apache-2.0"
 repository = "https://github.com/solverforge/solverforge-rs"

Cargo.toml

@@ -6,7 +6,7 @@ license.workspace = true
 description = "Configuration system for SolverForge constraint solver"
 
 [dependencies]
-solverforge-core = { version = "0.5.1", path = "../solverforge-core" }
+solverforge-core = { version = "0.6.0", path = "../solverforge-core" }
 serde.workspace = true
 toml.workspace = true
 serde_yaml.workspace = true

crates/solverforge-config/Cargo.toml

@@ -43,6 +43,7 @@ use crate::solution::DynamicSolution;
 ///
 /// A boxed `IncrementalConstraint<DynamicSolution, HardSoftScore>` that can be stored
 /// in `DynamicConstraintSet`.
+#[allow(clippy::too_many_arguments)]
 pub fn build_bi_self_constraint(
     constraint_ref: ConstraintRef,
     impact_type: ImpactType,
@@ -106,6 +107,7 @@ pub fn build_bi_self_constraint(
 ///
 /// A boxed `IncrementalConstraint<DynamicSolution, HardSoftScore>` that can be stored
 /// in `DynamicConstraintSet`.
+#[allow(clippy::too_many_arguments)]
 pub fn build_tri_self_constraint(
     constraint_ref: ConstraintRef,
     impact_type: ImpactType,

crates/solverforge-dynamic/src/constraint/factory_self.rs

@@ -49,6 +49,7 @@ use crate::solution::DynamicSolution;
 ///
 /// A boxed `IncrementalConstraint<DynamicSolution, HardSoftScore>` that can be stored
 /// in `DynamicConstraintSet`.
+#[allow(clippy::too_many_arguments)]
 pub fn build_quad_self_constraint(
     constraint_ref: ConstraintRef,
     impact_type: ImpactType,
@@ -119,6 +120,7 @@ pub fn build_quad_self_constraint(
 ///
 /// A boxed `IncrementalConstraint<DynamicSolution, HardSoftScore>` that can be stored
 /// in `DynamicConstraintSet`.
+#[allow(clippy::too_many_arguments)]
 pub fn build_penta_self_constraint(
     constraint_ref: ConstraintRef,
     impact_type: ImpactType,

crates/solverforge-dynamic/src/constraint/factory_self_higher.rs

@@ -19,33 +19,5 @@ mod stream_ops;
 mod stream_parser;
 mod types;
 
-// Re-export type aliases
-pub use types::{
-    DynALookup, DynBiFilter, DynBiWeight, DynCKeyFn, DynCrossExtractorA, DynCrossExtractorB,
-    DynCrossFilter, DynCrossKeyA, DynCrossKeyB, DynCrossWeight, DynExtractor, DynFlatten,
-    DynFlattenedFilter, DynFlattenedWeight, DynKeyExtractor, DynPentaFilter, DynPentaWeight,
-    DynQuadFilter, DynQuadWeight, DynTriFilter, DynTriWeight, DynUniFilter, DynUniWeight,
-};
-
-// Re-export closure builders
-pub use closures_bi::{make_bi_filter, make_bi_weight};
-pub use closures_cross::{
-    make_cross_extractor_a, make_cross_extractor_b, make_cross_filter, make_cross_key_a,
-    make_cross_key_b, make_cross_weight,
-};
-pub use closures_extract::{make_extractor, make_key_extractor};
-pub use closures_flattened::{
-    make_a_lookup, make_c_key_fn, make_flatten, make_flattened_filter, make_flattened_weight,
-};
-pub use closures_penta::{make_penta_filter, make_penta_weight};
-pub use closures_quad::{make_quad_filter, make_quad_weight};
-pub use closures_tri::{make_tri_filter, make_tri_weight};
-
-// Re-export factory functions
-pub use factory_cross::{build_cross_bi_constraint, build_flattened_bi_constraint};
-pub use factory_self::{build_bi_self_constraint, build_tri_self_constraint};
-pub use factory_self_higher::{build_penta_self_constraint, build_quad_self_constraint};
-pub use factory_uni::build_uni_constraint;
-
 // Re-export stream operations
 pub use stream_ops::{build_from_stream_ops, StreamOp};

crates/solverforge-dynamic/src/constraint/mod.rs

@@ -7,9 +7,6 @@ use crate::expr::Expr;
 use crate::solution::{DynamicEntity, DynamicSolution, DynamicValue};
 use solverforge_core::score::HardSoftScore;
 use solverforge_core::{ConstraintRef, ImpactType};
-use solverforge_scoring::api::constraint_set::IncrementalConstraint;
-
-// Note: ConstraintRef::new requires (package, name), so we use empty package for dynamic constraints
 use solverforge_scoring::ConstraintSet;
 
 fn make_nqueens_solution(rows: &[i64]) -> DynamicSolution {

crates/solverforge-dynamic/src/constraint/tests.rs

@@ -1,7 +1,6 @@
 //! Constraint set implementation for dynamic constraints.
 
 use solverforge_core::score::HardSoftScore;
-use solverforge_core::ConstraintRef;
 use solverforge_scoring::api::analysis::ConstraintAnalysis;
 use solverforge_scoring::api::constraint_set::{
     ConstraintResult, ConstraintSet, IncrementalConstraint,
@@ -24,14 +23,12 @@ impl Default for DynamicConstraintSet {
 }
 
 impl DynamicConstraintSet {
-    /// Creates a new empty constraint set.
     pub fn new() -> Self {
         Self {
             constraints: Vec::new(),
         }
     }
 
-    /// Creates a constraint set from a vector of boxed constraints.
     pub fn from_vec(
         constraints: Vec<
             Box<dyn IncrementalConstraint<DynamicSolution, HardSoftScore> + Send + Sync>,
@@ -40,20 +37,17 @@ impl DynamicConstraintSet {
         Self { constraints }
     }
 
-    /// Adds a boxed constraint to the set.
     pub fn add(
         &mut self,
         constraint: Box<dyn IncrementalConstraint<DynamicSolution, HardSoftScore> + Send + Sync>,
     ) {
         self.constraints.push(constraint);
     }
 
-    /// Returns the number of constraints in the set.
     pub fn len(&self) -> usize {
         self.constraints.len()
     }
 
-    /// Returns true if the constraint set is empty.
     pub fn is_empty(&self) -> bool {
         self.constraints.is_empty()
     }