Skip to content

Commit 7c46b23

Browse files
committed
Revert to not using a resource pack for the built-in vanilla sound pack.
Given the problems this has caused it's evident we can only rely on this feature for non-essential things.
1 parent 37307e2 commit 7c46b23

File tree

922 files changed

+0
-24
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

922 files changed

+0
-24
lines changed

src/main/java/eu/ha3/presencefootsteps/PFConfig.java

-10
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ public class PFConfig extends JsonFile {
2424
private int maxSteppingEntities = 50;
2525

2626
private boolean disabled = false;
27-
private boolean firstRun = true;
2827
private boolean multiplayer = true;
2928
private boolean global = true;
3029
private boolean footwear = true;
@@ -71,15 +70,6 @@ public boolean isVisualiserRunning() {
7170
return visualiser;
7271
}
7372

74-
public boolean isFirstRun() {
75-
return firstRun;
76-
}
77-
78-
public void setNotFirstRun() {
79-
firstRun = false;
80-
save();
81-
}
82-
8373
public Locomotion getLocomotion() {
8474
return stance == null ? Locomotion.NONE : stance;
8575
}

src/main/java/eu/ha3/presencefootsteps/PresenceFootsteps.java

-14
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents;
1818
import net.fabricmc.fabric.api.client.keybinding.v1.KeyBindingHelper;
1919
import net.fabricmc.fabric.api.resource.ResourceManagerHelper;
20-
import net.fabricmc.fabric.api.resource.ResourcePackActivationType;
2120
import net.fabricmc.loader.api.FabricLoader;
2221
import net.minecraft.client.MinecraftClient;
2322
import net.minecraft.client.option.KeyBinding;
@@ -36,7 +35,6 @@ public class PresenceFootsteps implements ClientModInitializer {
3635
private static final String UPDATER_ENDPOINT = "https://raw.githubusercontent.com/Sollace/Presence-Footsteps/master/version/latest.json";
3736

3837
public static final Text MOD_NAME = Text.translatable("mod.presencefootsteps.name");
39-
private static final Text SOUND_PACK_NAME = Text.translatable("pf.default_sounds.name");
4038

4139
public static Identifier id(String name) {
4240
return Identifier.of(MODID, name);
@@ -101,10 +99,6 @@ public void onInitializeClient() {
10199

102100
ClientTickEvents.END_CLIENT_TICK.register(this::onTick);
103101
ResourceManagerHelper.get(ResourceType.CLIENT_RESOURCES).registerReloadListener(engine);
104-
105-
FabricLoader.getInstance().getModContainer("presencefootsteps").ifPresent(container -> {
106-
ResourceManagerHelper.registerBuiltinResourcePack(id("default_sound_pack"), container, SOUND_PACK_NAME, ResourcePackActivationType.DEFAULT_ENABLED);
107-
});
108102
}
109103

110104
private void onTick(MinecraftClient client) {
@@ -128,14 +122,6 @@ private void onTick(MinecraftClient client) {
128122
if (!FabricLoader.getInstance().isModLoaded("modmenu")) {
129123
updater.attempt();
130124
}
131-
132-
if (config.getEnabled() && !engine.hasData() && config.isFirstRun()) {
133-
config.setNotFirstRun();
134-
showSystemToast(
135-
Text.translatable("key.presencefootsteps.settings"),
136-
Text.translatable("pf.default_sounds.missing", SOUND_PACK_NAME)
137-
);
138-
}
139125
});
140126
}
141127

0 commit comments

Comments
 (0)