Fix: fixed try-catch for deciding acl-acp util

Author: Dexagod

src/shell/commands/perms.ts

@@ -32,7 +32,6 @@ export default class PermsCommand extends SolidCommand {
         const authenticationInfo = await authenticate(programOpts)
         options.fetch = authenticationInfo.fetch
         url = await changeUrlPrefixes(authenticationInfo, url)
-        
 
         const { acp, acl } = await discoverAccessMechanism(url, options.fetch)
         if ( !acp && !acl ) {
@@ -47,7 +46,7 @@ export default class PermsCommand extends SolidCommand {
               return;
             }   
           } catch (e) {
-            if (options.verbose) writeErrorString('Unable to list permissions for WAC', e, options)
+            if (options.verbose) writeErrorString('Unable to list permissions using WAC', e, options)
           }
         }
         if (acp) {
@@ -65,7 +64,6 @@ export default class PermsCommand extends SolidCommand {
         if (this.mayExit) process.exit(0)
       })
 
-
     access
       .command('set')
       .argument('<url>', 'Resource URL')
@@ -96,7 +94,7 @@ export default class PermsCommand extends SolidCommand {
             }
             let id = splitPerm[0]
             const permissionOptions = splitPerm[1].split('')
-            let type;
+            let type = 'agent';
 
             if (options.group) {
               type = 'group'
@@ -107,7 +105,6 @@ export default class PermsCommand extends SolidCommand {
                 writeErrorString('Could not autmatically fill in webId of authenticated user.', 'Please make sure you have an authenticated session to auto-fill your webId', options);
                 process.exit(0)
               }
-              type = 'agent'
               id = authenticationInfo.webId
             } 
             const read = permissionOptions.indexOf('r') !== -1

src/utils/util.ts

@@ -507,14 +507,18 @@ export async function isRDFResource(fileInfo: FileInfo, fetch: any) {
 
 export async function discoverAccessMechanism(url: string, fetch: any) {
   // We need to first check acp because Inrupt libs are kinda wack and reuse of acl rel header is confusing their own libs.
-  const acpInfo = await acp_ess_2.getResourceInfoWithAcr(url, { fetch })  
-  const acp = acp_ess_2.hasAccessibleAcr(acpInfo)
-  if (acp) return({ acp: true, acl: false })
-
+  try {
+    const acpInfo = await acp_ess_2.getResourceInfoWithAcr(url, { fetch })  
+    const acp = acp_ess_2.hasAccessibleAcr(acpInfo)
+    if (acp) return({ acp: true, acl: false })
+  } catch {}
+  
   // Now we check acl
-  const dataset = await acp_ess_2.getResourceInfoWithAccessDatasets(url, { fetch })  
-  const acl = hasAccessibleAcl(dataset) && !acp
-  if (acl) return({ acp: false, acl: true })
-
+  try {
+    const dataset = await acp_ess_2.getResourceInfoWithAccessDatasets(url, { fetch })  
+    const acl = hasAccessibleAcl(dataset) // && !acp -> is implicit here
+    if (acl) return({ acp: false, acl: true })
+  } catch {}
+  
   return ({ acp: false, acl: false })
 }