test: hold the negation twins and the size table to the tree

Author: Solganis

ARCHITECTURE.md

@@ -23,6 +23,7 @@ Most of it is not yours to edit:
 | `_engine/_builder_check_typing.py` | 1 | 315 |
 | `_engine/_capable_typing.py` | 10 | 324 |
 | `_engine/_poll_typing.py` | 2 | 739 |
+| `_engine/_negated_typing.py` | 18 | 862 |
 
 One is written by hand. `tests/test_architecture_doc.py` recomputes this table. No line counts, which
 move on every edit to a generated file.
@@ -39,12 +40,13 @@ move on every edit to a generated file.
 | `_engine/_negated_typing.py` | `scripts/generate_poll_protocols.py` | `_typing.py` and `_engine/_operations.py` |
 | `_engine/_check_typing.py` | `scripts/generate_check_protocols.py` | `_typing.py`, `_engine/_operations.py` |
 
-One script writes three of them. That is the part people miss.
+One script writes four of them. That is the part people miss.
 
 - **polling twins** answer `eventually()` and `eventually_sync()`, so every assertion hands back the chain.
 - **verdict twins** answer `check()`, returning an `AssertionOutcome` instead of `Self`.
 - **the capability façade** stands in for the builder itself, so it reads the mixins rather than the views:
   reading the views would narrow it to what one value type answers. It skips its own hand-written list.
+- **negation twins** answer `.not_`, where one assertion hands back the view the chain had before it.
 
 `_engine/_operations.py` decides what the first two leave out: `NOT_AN_OPERATION`, `WITHOUT_A_VERDICT`.
 
@@ -111,7 +113,7 @@ import lines are templates inside the generators.
 | `test_typing_completeness.py` | can a checker name a type for every exported symbol |
 | `test_pyright_baseline.py` | has a new pyright diagnostic appeared in the package |
 | `test_typing_promises.py` | is the object at the end of a chain the type the checker was promised |
-| `test_negated_protocols.py` | does every reachable view have a negation twin that hands the view back |
+| `test_negated_protocols.py` | does every reachable view have a negation twin that hands the view back, and is the file what the generator produces |
 | `test_architecture_doc.py` | does this document still describe the tree, counts included |
 | `test_typing_negative.py` | do the checkers still refuse what they should |
 | `test_typing_from_a_wheel.py` | does the typed surface survive packaging |
@@ -126,9 +128,9 @@ Which one goes red tells you what you did:
 
 - a declaration the runtime does not have: `test_protocol_parity.py`
 - a declaration whose parameters the runtime does not match: `test_typing_conformance.py`
-- a generated file edited by hand: that file's own gate, one of the three
-- a protocol changed without regenerating: the polling and verdict gates, never the facade one, which
-  reads the mixins instead
+- a generated file edited by hand: that file's own gate, one of the four
+- a protocol changed without regenerating: the polling, verdict and negation gates, never the facade one,
+  which reads the mixins instead
 - a subject resolving to the wrong protocol: `test_typing.py`, and only under whichever checker sees it
 - a public name added or moved: `test_api_compatibility.py`, which is a snapshot rather than a rule
 

tests/test_architecture_doc.py

@@ -25,14 +25,8 @@
 _SIZE_ROW = re.compile(
     r"^\| `(?P<file>_engine/[a-z_]+\.py)` \| (?P<protocols>\d+) \| (?P<declarations>\d+) \|", re.MULTILINE
 )
-_TYPED_MODULES = [
-    "_engine/_typing.py",
-    "_engine/_check_typing.py",
-    "_engine/_builder_check_typing.py",
-    "_engine/_capable_typing.py",
-    "_engine/_poll_typing.py",
-]
-"""The five, in the order the table lists them.  A sixth added to the package has to reach the table."""
+_TYPED_MODULES = sorted(f"_engine/{path.name}" for path in (_ROOT / "assertpy2" / "_engine").glob("*_typing.py"))
+"""Read off the tree rather than listed here, which let the negation twins go unrecorded."""
 
 
 def _named_paths() -> set[str]:
@@ -82,7 +76,8 @@ def test_the_table_of_sizes_is_what_the_files_hold() -> None:
     rows = _SIZE_ROW.findall(_DOCUMENT.read_text(encoding="utf-8"))
     listed = [module for module, _, _ in rows]
 
-    assert_that(listed).described_as("modules the table has a row for, one row each").is_equal_to(_TYPED_MODULES)
+    assert_that(sorted(listed)).described_as("modules the table has a row for").is_equal_to(_TYPED_MODULES)
+    assert_that(listed).described_as("rows per module").does_not_contain_duplicates()
     assert_that({module: (int(protocols), int(declarations)) for module, protocols, declarations in rows}).described_as(
         "protocols and declarations per module, which ARCHITECTURE.md states outright"
     ).is_equal_to({module: _measured(module) for module in listed})

tests/test_capable_protocol.py

@@ -349,11 +349,11 @@ def _generator() -> ModuleType:
     return generate_poll_protocols
 
 
-def _formatted(source: str) -> str:
-    """Both steps the generator runs after writing, so the comparison is of the same thing twice."""
+def _formatted(source: str, path: str = _capable_typing.__file__) -> str:
+    """*source* after the two steps the generator runs once it has written *path*: ruff format, then ruff's fixes."""
     for command in (
-        ["ruff", "format", "--stdin-filename", _capable_typing.__file__, "-"],
-        ["ruff", "check", "--fix", "--quiet", "--stdin-filename", _capable_typing.__file__, "-"],
+        ["ruff", "format", "--stdin-filename", path, "-"],
+        ["ruff", "check", "--fix", "--quiet", "--stdin-filename", path, "-"],
     ):
         result = subprocess.run(
             [sys.executable, "-m", *command],

tests/test_negated_protocols.py

@@ -23,6 +23,7 @@
     TRANSFORMS,
     WITHOUT_A_VERDICT,
 )
+from tests.test_capable_protocol import _formatted, _generator
 
 _ROOT = pathlib.Path(__file__).resolve().parent.parent
 _VIEWS = _ROOT / "assertpy2" / "_engine" / "_typing.py"
@@ -391,3 +392,15 @@ class _Wanted(_Middle[str], Protocol): ...
     assert_that(_bound("_Wanted", known)).described_as("the substitution down each path").is_equal_to(
         [("_Wanted", {}), ("_Middle", {"_Y": "str"}), ("_Held", {"_X": "list[str]"}), ("_Plain", {})]
     )
+
+
+def test_the_file_is_what_the_generator_writes() -> None:
+    """Every test above checks the rule, so a hand edit that keeps it passed them all and a rerun erased it.
+
+    The file as it stands against what the generator writes after ruff, so a formatting-only hand edit
+    shows too: formatting both sides would even it out.  Line endings are read as text on both sides,
+    so a file differing only in those still passes.
+    """
+    assert_that(_formatted(_generator().generate_negated(), str(_TWINS))).described_as(
+        "the negation twins are out of step; run python scripts/generate_poll_protocols.py"
+    ).is_equal_to(_TWINS.read_text(encoding="utf-8"))