From 8765a39e47254d816ff23dc843b7f163dcf3a0c8 Mon Sep 17 00:00:00 2001 From: Soleone Date: Tue, 22 Sep 2020 14:36:46 -0400 Subject: [PATCH] Version 0.1.2, see changelog. Signup fix. --- CHANGELOG.md | 7 +++++++ ROADMAP.md | 10 ++++++---- src/App.vue | 5 +++-- src/components/FirebaseUI.vue | 2 +- src/store/index.js | 13 +++++++++++++ src/views/Player.vue | 11 +++-------- 6 files changed, 33 insertions(+), 15 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 98d0117..1d3bec7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +### 0.1.2 + +- Fix login bug +- Fix available button disabled state +- Temporarily disable code form validation +- Redirect to player profile right away after succesful sign up + ## 0.1.1 - Prevent setting to available when challenge code is empty diff --git a/ROADMAP.md b/ROADMAP.md index a2ad299..ebce166 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -7,14 +7,14 @@ None of this is guaranteed to be worked on by anyone. ## Milestones -### 0.1.2 - -- See number of online users (recently logged in) - ### 0.1.3 +- Bugfix: Re-enabled and fix form code validation +- See number of online users (recently logged in) +- Allow status message to be displayed (e.g. bugs) - Notifications when challenges are made available - Browser notification API? + - [Firebase Cloud Messaging](https://firebase.google.com/docs/cloud-messaging) ### 0.1.4 @@ -66,3 +66,5 @@ None of this is guaranteed to be worked on by anyone. - Matchup wanted (God, deck type) - Decklist - Announcement post? Voice? +- Mark challenge as connected to help other players to try to queue with you anymore +- Quick copy button diff --git a/src/App.vue b/src/App.vue index 9e7f702..295154a 100644 --- a/src/App.vue +++ b/src/App.vue @@ -34,7 +34,7 @@ label="Available" class="force-height mr-2" @change="updateAvailability()" - :disabled="player.challenge.code.toString() == ''" + :disabled="!isAvailableEnabled" > @@ -104,6 +104,7 @@ export default { ...mapState(['user', 'status']), ...mapGetters({ userName: 'userName', + isAvailableEnabled: 'isAvailableEnabled', player: 'playerObject' }) }, @@ -119,7 +120,7 @@ export default { }, data() { return { - version: '0.1.1' + version: '0.1.2' } }, methods: { diff --git a/src/components/FirebaseUI.vue b/src/components/FirebaseUI.vue index 3e59f16..7861956 100644 --- a/src/components/FirebaseUI.vue +++ b/src/components/FirebaseUI.vue @@ -47,7 +47,7 @@ export default { }) this.$gtag.event('playerCreated') } - this.$router.push('/') + this.$router.push({ name: 'Player' }) }) }, uiShown: () => { diff --git a/src/store/index.js b/src/store/index.js index 8991345..e98d463 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -126,6 +126,19 @@ export default new Vuex.Store({ challenge.player = new Player(player) return challenge }) + }, + isAvailableEnabled(state) { + if (!state.player) { + return false + } else if (!state.player.challenge) { + return false + } else if (!state.player.challenge.code) { + return false + } else if (state.player.challenge.code === '') { + return false + } else { + return true + } } }, modules: {} diff --git a/src/views/Player.vue b/src/views/Player.vue index 257ff1d..9f324c4 100644 --- a/src/views/Player.vue +++ b/src/views/Player.vue @@ -4,7 +4,7 @@ - + Once you entered a challenge code you can set yourself to available using the switch in the top menu bar. @@ -136,13 +136,7 @@ export default { ], rules: { code: { - length: value => { - return ( - value == '' || - (value && value.length >= 3 && value.length <= 40) || - 'Needs to be between 3 and 40 characters.' - ) - } + length: value => true } } } @@ -150,6 +144,7 @@ export default { computed: { ...mapState(['user']), ...mapGetters({ + isAvailableEnabled: 'isAvailableEnabled', player: 'playerObject' }) },