Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serializer_fields.CountryField fails to deserialize localized country names #407

Open
suhenkiy opened this issue Dec 1, 2022 · 1 comment
Open

serializer_fields.CountryField fails to deserialize localized country names #407

suhenkiy opened this issue Dec 1, 2022 · 1 comment
Labels
api

Comments

@suhenkiy
Copy link

suhenkiy commented Dec 1, 2022

ContryField doesn't pass a language parameter to countries.by_name, so deserialization fails if the country name not in English.
@SmileyChris
Copy link
Owner

It does seem like this could be a good enhancement/fix.

I haven't looked at the DRF field in a while, should be an easy implementation for someone to tackle

@SmileyChris SmileyChris added the api label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SmileyChris @suhenkiy