Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows version's savepath goes to a non-existent location and errors out instead of creating it, and is also not an easily settable location (if you can't edit LUA). #21

Open
Amariithynar opened this issue Aug 9, 2021 · 0 comments

Comments

@Amariithynar
Copy link

Amariithynar commented Aug 9, 2021

Currently, it's set to path = "C:\\Temp\\" which is a) a location that does not exist, b) not the correct formatting for Windows (no idea why you have it set to \\ if it's Windows specifically; maybe the parser you wrote it in uses backslashes as escape characters?). Furthermore, it doesn't attempt to create the location if no such location exists. As such, it spams about three dozen CMD windows all saying that no such location exists, and then finally crashes the extension entirely, though it doesn't impact VLC even if it's running at the time, thankfully.

It's a simple enough manual "fix" with minimum effort involved in that I can simply go create a "Temp" folder in my C:\ drive, but that's a) not with my music, and b) not where I want to put it, so fixing it as a better solution requires a little LUA editing to resolve (Note to anyone who is doing this themselves: Make sure you use Notepad++ or something similar, as VLC doesn't seem to like it when you edit and save LUAs using simple Notepad, and refuses to recognize it afterwards) by changing the function click_save() code as follows:

if platform == "windows" then
path = "C:\\Users\\Amariithynar\\Music\\Lyrics\\"

All this said, I'd request that you please make it so that the save path is something that can be set from within the plugin window popup so that this issue doesn't crop up going forward, and for other users. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant