-
Notifications
You must be signed in to change notification settings - Fork 499
Feature/matter britzyhub #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/matter britzyhub #2189
Conversation
@KyuminAhn And, there was no difference between the existing EdgeDriver and the EdgeDriver related to the dimming-light, elevator, gas-valve, etc. you made. If a Bridged Device can operate with the existing Matter Generic EdgeDriver, no separate EdgeDriver code is required. That is, if it can be operated as a Matter Generic EdgeDriver, the EdgeDriver suitable for the Bridged Device is automatically downloaded when the Bridge Device is onboarded without further development. If you have your own Bridged Device function that cannot be supported by Matter Generic EdgeDriver, you'd better implement the EdgeDriver for the separated directory at this time. However, even in this case, it would be better to implement the function under the directory such as matter-switch or matter-sensor, matter-thermostat, ... depending on the characteristics of the Bridged Device. This is because duplicate code can be minimized. @hcarter-775 , @nickolas-deboom |
drivers/SmartThings/sinux-britzyhub/src/air-conditioner/init.lua
Outdated
Show resolved
Hide resolved
- add DeviceTypeId to gas, vent, elevator in lua code - change valve capabilitiy of gas-valve to safetyValve
}, | ||
capability_handlers = { | ||
[valve_cap.ID] = { | ||
--[valve_cap.commands.open.NAME] = function(driver, device, cmd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be commented out accidentally
drivers/SmartThings/sinux-britzyhub/src/air-conditioner/init.lua
Outdated
Show resolved
Hide resolved
drivers/SmartThings/sinux-britzyhub/src/air-conditioner/init.lua
Outdated
Show resolved
Hide resolved
…ies and streamline event handling
Check all that apply
Type of Change
Checklist
Description of Change
Initial Commit of matter-britzyhub edge driver
Summary of Completed Tests
Tested gas valve
Tested elevator
Tested dimming light