initialize does not validate admin is not zero address

[ritaifeoluwa]

Description

The Factory contract does not validate that the admin address is not the zero address. A zero-address admin would make the factory permanently locked.

Current behavior

pub fn initialize(
    env: Env,
    admin: Address,
    pool_wasm_hash: BytesN<32>,
) -> Result<(), FactoryError> {
    // No check on admin
}

Expected behavior

Add validation:

assert!(admin != Address::zero(&env), "Admin cannot be zero address");

Why this matters

Setting admin to zero would make all admin functions permanently unusable.

Labels

security, good first issue

[Favouratambi]

@Favouratambi has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I'd love to work on this issue. I'll keep the implementation simple, clean, and well-tested.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Favouratambi to this issue.

[Abdulrasaq1515]

@Abdulrasaq1515 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I want to fix the initialization function because the Factory contract does not validate that the admin address is not the zero address. A zero-address admin would make the factory permanently locked. The fix adds a validation check: assert!(admin != Address::zero(&env), "Admin cannot be zero address").

Relevant experience:

Zero address validation — added zero-address checks to 3 initialize functions; prevent lockout

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Abdulrasaq1515 to this issue.

[oomokaro1]

@oomokaro1 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I would love to work on this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @oomokaro1 to this issue.

[drips-wave]

Congratulations, @oomokaro1! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @oomokaro1: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Third Campaign campaign!

@oomokaro1's PR #214 was approved and merged by @ritaifeoluwa.

🏆 @oomokaro1: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (707 total points). Track your full progress on GrantFox.

👏 Great work, @oomokaro1! Keep contributing to SmartDropLabs.

[drips-wave]

This issue has been completed by @oomokaro1 as part of the Stellar Wave Program's 8th Wave 🥳

😎 @oomokaro1: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.