get_pools_by_asset has no caching or secondary index

[ritaifeoluwa]

Description

The Factory contract's get_pools_by_asset function does not cache or index results. Each call scans up to 200 pool IDs, even if the same query was made recently.

Current behavior

Every call scans from start_id, checking each pool's asset field.

Expected behavior

Consider:

• Maintaining a secondary index (DataKey::AssetPools)
• Or caching recent query results
• Or allowing callers to provide a hint based on previous results

Why this matters

Frequent queries for popular assets will repeatedly scan the same pools, wasting gas.

Labels

performance, factory, hard

[Achievers-sketch]

@Achievers-sketch has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Optimize get_pools_by_asset by introducing an asset-based secondary index or query-result caching, reducing repeated scans and gas costs for popular assets.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Achievers-sketch to this issue.

[rahmanabimbs]

@rahmanabimbs has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I love to fix this issue, kindly assign it to me. Thanks

ℹ️ Repo Maintainers: To accept this application, review their application or assign @rahmanabimbs to this issue.

[drips-wave]

Congratulations, @rahmanabimbs! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @rahmanabimbs: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Third Campaign campaign!

@rahmanabimbs's PR #208 was approved and merged by @ritaifeoluwa.

🏆 @rahmanabimbs: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (83 total points). Track your full progress on GrantFox.

👏 Great work, @rahmanabimbs! Keep contributing to SmartDropLabs.

[drips-wave]

This issue has been completed by @rahmanabimbs as part of the Stellar Wave Program's 8th Wave 🥳

😎 @rahmanabimbs: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.