Make changes according to review

Author: joaosimbiose

SlicingDice.cpp

@@ -5,28 +5,28 @@ SlicingDice::SlicingDice(String apiUserKey) {
     host = "api.slicingdice.com";
     port = 80;
     apiKey = apiUserKey;
-    test = 0;
+    useProduction = true;
 }
 
 SlicingDice::SlicingDice(String apiUserKey, const char* customHost) {
     host = customHost;
     port = 80;
     apiKey = apiUserKey;
-    test = 0;
+    useProduction = true;
 }
 
 SlicingDice::SlicingDice(String apiUserKey, const char* customHost, int customPort) {
     host = customHost;
     port = customPort;
     apiKey = apiUserKey;
-    test = 0;
+    useProduction = true;
 }
 
-SlicingDice::SlicingDice(String apiUserKey, const char* customHost, int customPort, int customTest) {
+SlicingDice::SlicingDice(String apiUserKey, const char* customHost, int customPort, boolean production) {
     host = customHost;
     port = customPort;
     apiKey = apiUserKey;
-    test = customTest;
+    useProduction = production;
 }
 
 /* Index data on Slicing Dice API
@@ -51,11 +51,12 @@ void SlicingDice::makeRequest(const char* query){
 
     String testEndPoint = String("");
 
-    if (test == 1) {
+    if (!useProduction) {
         testEndPoint = String("test/");
     }
 
     client.println("POST /v1/" + testEndPoint + "index HTTP/1.1");
+    Serial.println("POST /v1/" + testEndPoint + "index HTTP/1.1");
     client.println(F("Content-Type: application/json"));
     String hostString = String(host);
     client.println("Host: " + hostString);

SlicingDice.h

@@ -10,7 +10,7 @@ class SlicingDice {
 	SlicingDice(String apiUserKey);
 	SlicingDice(String apiUserKey, const char* customHost);
 	SlicingDice(String apiUserKey, const char* customHost, int customPort);
-  	SlicingDice(String apiUserKey, const char* customHost, int customPort, int customTest);
+  	SlicingDice(String apiUserKey, const char* customHost, int customPort, boolean production);
 
 	void index(JsonObject& query);
 	int statusCode;
@@ -23,6 +23,6 @@ class SlicingDice {
 	String apiKey;
 	const char* host;
 	int port;
-	int test;
+	boolean useProduction;
 	EthernetClient client;
 };

tests_and_examples/Simple.ino

@@ -2,12 +2,12 @@
 #include <ArduinoJson.h>
 
 // Demo API key, if you need a new demo API key visit: https://panel.slicingdice.com/docs/#api-details-api-connection-api-keys-demo-key
-String apiKey = String("eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJfX3NhbHQiOiJkZW1vNTZtIiwicGVybWlzc2lvbl9sZXZlbCI6MywicHJvamVjdF9pZCI6MjE3LCJjbGllbnRfaWQiOjEwfQ.rKHWahhcTN8Hvhns8-O2_KwjC_b3SFHd3kqZLyDMrfc");
+String apiKey = String("eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJfX3NhbHQiOiJkZW1vMThtIiwicGVybWlzc2lvbl9sZXZlbCI6MywicHJvamVjdF9pZCI6MTc5LCJjbGllbnRfaWQiOjEwfQ.OTb6REW9JtYF9wVUZhXajq4wheU5ULNbM5iEmMCYhhM");
 const char* host = "api.slicingdice.com";
 int port = 80;
-// test = 1 indicates that will use test end-point, 0 indicates will use production end-point
-int test = 1;
-SlicingDice sd = SlicingDice(apiKey, host, port, test);
+// if false will use test end-point, otherwise production end-point
+int useProduction = false;
+SlicingDice sd = SlicingDice(apiKey, host, port, useProduction);
 
 void setup() {
     // Open serial communications and wait for port to open: