From e0a48dd974fda552a90eaf8cf8b638b09399f01c Mon Sep 17 00:00:00 2001 From: Elliot Sutton Date: Sat, 1 Mar 2025 14:37:32 +0100 Subject: [PATCH] fix(core,react,docs): replace ARIA roles with CSS class selectors for accessibility --- apps/docs/content/docs/configure.mdx | 20 ++++++++-------- apps/docs/content/docs/installation.mdx | 6 ++--- apps/docs/content/docs/migration.mdx | 23 +++++++++++++++++- apps/docs/content/docs/next/whats-new.mdx | 2 +- apps/docs/content/docs/quick-start.mdx | 2 +- .../components/progress-components/bar.mdx | 1 - .../progress-components/spinner.mdx | 1 - apps/docs/content/docs/roadmap.mdx | 2 +- apps/docs/content/docs/upgrade.mdx | 8 +++---- apps/html/index.html | 6 ++--- packages/core/CHANGELOG.md | 8 +++++++ packages/core/README.md | 8 +++---- packages/core/__tests__/progress.test.ts | 24 +++++++++---------- packages/core/package.json | 2 +- packages/core/src/progress.ts | 10 ++++---- packages/next/CHANGELOG.md | 6 +++++ packages/next/package.json | 6 ++--- packages/react/CHANGELOG.md | 8 +++++++ .../react/__tests__/components/bar.test.tsx | 4 ++-- .../__tests__/components/spinner.test.tsx | 4 ++-- packages/react/package.json | 4 ++-- packages/react/src/components/bar.tsx | 10 +------- packages/react/src/components/peg.tsx | 2 +- packages/react/src/components/progress.tsx | 2 +- .../react/src/components/spinner-icon.tsx | 2 +- packages/react/src/components/spinner.tsx | 2 -- packages/react/src/types.ts | 2 -- packages/remix/CHANGELOG.md | 7 ++++++ packages/remix/package.json | 6 ++--- 29 files changed, 111 insertions(+), 77 deletions(-) create mode 100644 packages/core/CHANGELOG.md create mode 100644 packages/react/CHANGELOG.md create mode 100644 packages/remix/CHANGELOG.md diff --git a/apps/docs/content/docs/configure.mdx b/apps/docs/content/docs/configure.mdx index 0f4a20b..73c802f 100644 --- a/apps/docs/content/docs/configure.mdx +++ b/apps/docs/content/docs/configure.mdx @@ -13,16 +13,16 @@ The `configure()` method updates the default settings of the progress bar. BProgress.configure({ minimum: 0.08, maximum: 1, - template: `
-
`, + template: `
+
`, easing: 'linear', positionUsing: 'width', speed: 200, trickle: true, trickleSpeed: 200, showSpinner: true, - barSelector: '[role="bar"]', - spinnerSelector: '[role="spinner"]', + barSelector: '.bar', + spinnerSelector: '.spinner', parent: 'body', direction: 'ltr', }); @@ -77,15 +77,15 @@ type BProgressDirection = 'ltr' | 'rtl'; |----------|------------------------|------------------------------------|-----------------------------------------------| | minimum | number | 0.08 | The minimum percentage value between 0 and 1. | | maximum | number | 1 | The maximum percentage value between 0 and 1. | -| template | string \| null | `
` | The template of the progress bar. Classes are important for CSS, but if you have a custom CSS you can put any classes you like. The roles depend on those configured in the `barSelector` and `spinnerSelector` options. | +| template | string \| null | `
` | The template of the progress bar. Classes needs to match with the `barSelector` and `spinnerSelector` options. | | easing | string | 'linear' | The easing of the progress bar. | | positionUsing | BProgressPositionUsing | 'width' | The position using of the progress bar. | | speed | number | 200 | The speed of the progress bar. | | trickle | boolean | true | If `true`, the progress bar will trickle. | | trickleSpeed | number | 200 | The speed of the trickle. | | showSpinner | boolean | true | If `true`, the progress bar will show the spinner. | -| barSelector | string | '[role="bar"]' | The bar selector. | -| spinnerSelector | string | '[role="spinner"]' | The spinner selector. | +| barSelector | string | '.bar' | The bar selector. | +| spinnerSelector | string | '.spinner' | The spinner selector. | | parent | HTMLElement \| string | 'body' | The parent container of the progress bar. (if `template` is not `null`) | | direction | BProgressDirection | 'ltr' | The direction of the progress bar. | @@ -97,16 +97,16 @@ type BProgressDirection = 'ltr' | 'rtl'; ```html