From ea26a45d3039db3886b68a632d9b788f248a7ec1 Mon Sep 17 00:00:00 2001 From: Jerry Zhang Date: Sat, 28 Dec 2024 16:53:40 -0500 Subject: [PATCH] upload: Allow relative between different uploaders When originally adding Uploader, we didn't allow relative between different uploaders to be safe / prevent risk of mistakes. It seems like there's a decently large use case for this though, so switch to allowing it. Topic: relup Uploader: who Reviewers: aaron, brian-k --- revup/topic_stack.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/revup/topic_stack.py b/revup/topic_stack.py index 335d540..6b04295 100644 --- a/revup/topic_stack.py +++ b/revup/topic_stack.py @@ -647,16 +647,6 @@ async def populate_relative_reviews(self, uploader: str, branch_format: str) -> f" {topic.tags[TAG_BRANCH]} for topic {name}" ) - if ( - topic.tags[TAG_UPLOADER] - and topic.relative_topic - and topic.tags[TAG_UPLOADER] != topic.relative_topic.tags[TAG_UPLOADER] - ): - raise RevupUsageException( - f"Topic {name} has uploader '{topic.tags[TAG_UPLOADER]}' while relative topic" - f" {topic.relative_topic.name} has uploader" - f" {topic.relative_topic.tags[TAG_UPLOADER] or '{}'}" - ) topic_uploader = min(topic.tags[TAG_UPLOADER]) if topic.tags[TAG_UPLOADER] else uploader topic_branch_format = ( min(topic.tags[TAG_BRANCH_FORMAT]).lower()