Skip to content

Commit 835228b

Browse files
committed
Removed useless REGEX in string(REGEX REPLACE
1 parent b637337 commit 835228b

File tree

4 files changed

+4
-22
lines changed

4 files changed

+4
-22
lines changed

examples/cpp/CMakeLists.txt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,7 @@ add_custom_target(${PROJECT_NAME}-example-cpp)
77
file(GLOB_RECURSE ${PROJECT_NAME}_CPP_EXAMPLES *.cpp)
88
foreach(EXAMPLE_FILE ${${PROJECT_NAME}_CPP_EXAMPLES})
99
get_filename_component(EXAMPLE_NAME ${EXAMPLE_FILE} NAME_WE)
10-
string(
11-
REGEX REPLACE
12-
"${PROJECT_SOURCE_DIR}/"
13-
""
14-
EXAMPLE_FILE_REL
15-
${EXAMPLE_FILE}
16-
)
10+
string(REPLACE "${PROJECT_SOURCE_DIR}/" "" EXAMPLE_FILE_REL ${EXAMPLE_FILE})
1711

1812
string(REGEX REPLACE "^examples/cpp/" "" EXAMPLE_SUBPATH ${EXAMPLE_FILE_REL})
1913
get_filename_component(EXAMPLE_DIR ${EXAMPLE_SUBPATH} DIRECTORY)

examples/julia/CMakeLists.txt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
11
file(GLOB_RECURSE ${PROJECT_NAME}_JULIA_EXAMPLES *.jl)
22

33
foreach(EXAMPLE ${${PROJECT_NAME}_JULIA_EXAMPLES})
4-
string(
5-
REGEX REPLACE
6-
"${PROJECT_SOURCE_DIR}/examples/julia/"
7-
""
8-
EXAMPLE
9-
${EXAMPLE}
10-
)
4+
string(REPLACE "${PROJECT_SOURCE_DIR}/examples/julia/" "" EXAMPLE ${EXAMPLE})
115
ADD_JULIA_UNIT_TEST(
126
"${PROJECT_NAME}-example-jl-${EXAMPLE}"
137
"examples/julia/${EXAMPLE}"

examples/python/CMakeLists.txt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,7 @@ foreach(EXAMPLE_FILE ${${PROJECT_NAME}_PYTHON_EXAMPLES})
66
continue()
77
endif()
88

9-
string(
10-
REGEX REPLACE
11-
"${PROJECT_SOURCE_DIR}/"
12-
""
13-
EXAMPLE_FILE_REL
14-
${EXAMPLE_FILE}
15-
)
9+
string(REPLACE "${PROJECT_SOURCE_DIR}/" "" EXAMPLE_FILE_REL ${EXAMPLE_FILE})
1610

1711
string(
1812
REGEX REPLACE

test/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ if(BUILD_PYTHON_INTERFACE)
116116

117117
foreach(TEST_FILE ${${PROJECT_NAME}_PYTHON_UNITTEST})
118118
get_filename_component(TEST_NAME ${TEST_FILE} NAME_WE)
119-
string(REGEX REPLACE "${PROJECT_SOURCE_DIR}/" "" TEST_FILE_REL ${TEST_FILE})
119+
string(REPLACE "${PROJECT_SOURCE_DIR}/" "" TEST_FILE_REL ${TEST_FILE})
120120
string(REGEX REPLACE "^test/src/" "" TEST_SUBPATH ${TEST_FILE_REL})
121121
get_filename_component(TEST_DIR ${TEST_SUBPATH} DIRECTORY)
122122
if(TEST_DIR STREQUAL "")

0 commit comments

Comments
 (0)