Skip to content

Commit a32ce4f

Browse files
committed
core/errors.h : use string_view for _error_message_impl
1 parent 566942c commit a32ce4f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/candlewick/core/errors.cpp

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@ RAIIException::RAIIException(std::string_view msg,
99
location.file_name(), location.line(), msg.data())) {}
1010

1111
namespace detail {
12-
std::string _error_message_impl(const char *fname, std::string_view _fmtstr,
12+
std::string _error_message_impl(std::string_view fname,
13+
std::string_view fmtstr,
1314
std::format_args args) {
14-
return std::format("{:s} :: {:s}", fname, std::vformat(_fmtstr, args));
15+
return std::format("{:s} :: {:s}", fname, std::vformat(fmtstr, args));
1516
}
1617
} // namespace detail
1718
} // namespace candlewick

src/candlewick/core/errors.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ struct RAIIException : std::runtime_error {
2121

2222
namespace detail {
2323

24-
std::string _error_message_impl(const char *fname, std::string_view fmtstr,
24+
std::string _error_message_impl(std::string_view fname,
25+
std::string_view fmtstr,
2526
std::format_args args);
2627

2728
template <typename... Ts>

0 commit comments

Comments
 (0)