Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up unit tests #338

Open
1 task done
mrp089 opened this issue Feb 10, 2025 · 1 comment
Open
1 task done

Split up unit tests #338

mrp089 opened this issue Feb 10, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mrp089
Copy link
Member

mrp089 commented Feb 10, 2025

Problem

All our unit tests are in one long (>2000 lines) .cpp file. This makes it hard to see what we're currently testing and intimidating to add new tests.

Solution

Split up the test file logically into many .cpp files (like we do for integration tests). @arsLibera added code for the 1D solver to collect several unit test files.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@mrp089 mrp089 added enhancement New feature or request good first issue Good for newcomers labels Feb 10, 2025
@aabrown100-git
Copy link
Collaborator

I agree. Also, currently our "unit tests" are rather complicated tests of the solid material models (this was my doing). These might better be split up and placed in a folder called something more appropriate, and leave "unit tests" for true unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants