Fix beam_250ms and beam_1000ms flags always set to true

Problem: The beam_250ms and beam_1000ms fields in zwapi_tx_report_t
are incorrectly parsed from the Z-Wave module response, causing both
flags to always be reported as true regardless of whether beaming was
actually used during transmission.

Root Cause: In
applications/zpc/components/zwave_api/src/zwapi_protocol_rx_dispatch.c
at lines 428-429, the code uses bitwise OR (|) operator instead of
bitwise AND (&) operator when extracting beam flags from the received
byte. The OR operator sets the bits instead of testing them, resulting
in non-zero (true) values regardless of the actual bit state in the
received data.

These buggy lines were introduced in ver_1.0.2_cert-123-g914bebeb30.

Solution: Changed the bitwise operations to correctly test the bit flags:

    txStatusReport.beam_1000ms = (*p & (1 << 6)) != 0;  // Test bit 6
    txStatusReport.beam_250ms = (*p & (1 << 5)) != 0;   // Test bit 5

Testing: Added comprehensive test cases covering all beam flag
combinations to verify the flags now correctly reflect the actual
beaming usage from the Z-Wave module response.

Co-authored-by: [email protected]
Origin: #150
Thanks-to: Umer Qureshi @umer-iapts
Relate-to: #149
Bug-SiliconLabs: UIC-1061
Bug-SiliconLabs: UIC-1294

Author: Copilot

applications/zpc/components/zwave_api/src/zwapi_protocol_rx_dispatch.c

@@ -425,8 +425,8 @@ void zwave_api_protocol_rx_dispatch(uint8_t *pData, uint16_t len)
         txStatusReport.last_route_repeaters[3] = *p++;
 
         // Byte 16, beam and last route speed
-        txStatusReport.beam_1000ms      = (*p) | (1 << 6);
-        txStatusReport.beam_250ms       = (*p) | (1 << 5);
+        txStatusReport.beam_1000ms      = (*p & (1 << 6)) != 0;
+        txStatusReport.beam_250ms       = (*p & (1 << 5)) != 0;
         txStatusReport.last_route_speed = (*p++) & 0x7;
 
         txStatusReport.routing_attempts      = *p++;

applications/zpc/components/zwave_api/test/zwapi_protocol_rx_dispatch_test.c

@@ -522,3 +522,63 @@ void test_zwapi_protocol_rx_dispatch_protocol_cc_encryption_request()
   TEST_ASSERT_EQUAL(1,
                     zwapi_protocol_cc_encryption_request_test_function_call_count);
 }
+
+void test_zwapi_protocol_rx_dispatch_beam_flags_both_false()
+{
+  // Test with beam flags both false (bit 5 and 6 clear: 0x00)
+  zwave_api_get_callbacks_IgnoreAndReturn(&test_zwapi_callbacks);
+  zwapi_send_data_callback = &zwapi_send_data_test_callback;
+  uint8_t frame[] = {0x1D, 0x00, 0x13, 0x00, 0x00, 0x12, 0x23, 0x05, 0xCF, 0x7D,
+                     0x7F, 0x6F, 0x7F, 0x01, 0x01, 0x03, 0x00, 0x00, 0x00, 0x00,
+                     0x00, 0x01, 0x00, 0x00};  // Byte 20 = 0x00 (no beam flags set)
+  zwave_api_protocol_rx_dispatch(frame, sizeof(frame));
+
+  TEST_ASSERT_EQUAL(1, zwapi_send_data_test_callback_call_count);
+  TEST_ASSERT_EQUAL(false, received_tx_report.beam_1000ms);
+  TEST_ASSERT_EQUAL(false, received_tx_report.beam_250ms);
+}
+
+void test_zwapi_protocol_rx_dispatch_beam_flags_250ms_only()
+{
+  // Test with only beam_250ms flag set (bit 5 set: 0x20)
+  zwave_api_get_callbacks_IgnoreAndReturn(&test_zwapi_callbacks);
+  zwapi_send_data_callback = &zwapi_send_data_test_callback;
+  uint8_t frame[] = {0x1D, 0x00, 0x13, 0x00, 0x00, 0x12, 0x23, 0x05, 0xCF, 0x7D,
+                     0x7F, 0x6F, 0x7F, 0x01, 0x01, 0x03, 0x00, 0x00, 0x00, 0x00,
+                     0x20, 0x01, 0x00, 0x00};  // Byte 20 = 0x20 (bit 5 set)
+  zwave_api_protocol_rx_dispatch(frame, sizeof(frame));
+
+  TEST_ASSERT_EQUAL(1, zwapi_send_data_test_callback_call_count);
+  TEST_ASSERT_EQUAL(false, received_tx_report.beam_1000ms);
+  TEST_ASSERT_EQUAL(true, received_tx_report.beam_250ms);
+}
+
+void test_zwapi_protocol_rx_dispatch_beam_flags_1000ms_only()
+{
+  // Test with only beam_1000ms flag set (bit 6 set: 0x40)
+  zwave_api_get_callbacks_IgnoreAndReturn(&test_zwapi_callbacks);
+  zwapi_send_data_callback = &zwapi_send_data_test_callback;
+  uint8_t frame[] = {0x1D, 0x00, 0x13, 0x00, 0x00, 0x12, 0x23, 0x05, 0xCF, 0x7D,
+                     0x7F, 0x6F, 0x7F, 0x01, 0x01, 0x03, 0x00, 0x00, 0x00, 0x00,
+                     0x40, 0x01, 0x00, 0x00};  // Byte 20 = 0x40 (bit 6 set)
+  zwave_api_protocol_rx_dispatch(frame, sizeof(frame));
+
+  TEST_ASSERT_EQUAL(1, zwapi_send_data_test_callback_call_count);
+  TEST_ASSERT_EQUAL(true, received_tx_report.beam_1000ms);
+  TEST_ASSERT_EQUAL(false, received_tx_report.beam_250ms);
+}
+
+void test_zwapi_protocol_rx_dispatch_beam_flags_both_true()
+{
+  // Test with both beam flags set (bits 5 and 6 set: 0x60)
+  zwave_api_get_callbacks_IgnoreAndReturn(&test_zwapi_callbacks);
+  zwapi_send_data_callback = &zwapi_send_data_test_callback;
+  uint8_t frame[] = {0x1D, 0x00, 0x13, 0x00, 0x00, 0x12, 0x23, 0x05, 0xCF, 0x7D,
+                     0x7F, 0x6F, 0x7F, 0x01, 0x01, 0x03, 0x00, 0x00, 0x00, 0x00,
+                     0x60, 0x01, 0x00, 0x00};  // Byte 20 = 0x60 (bits 5 and 6 set)
+  zwave_api_protocol_rx_dispatch(frame, sizeof(frame));
+
+  TEST_ASSERT_EQUAL(1, zwapi_send_data_test_callback_call_count);
+  TEST_ASSERT_EQUAL(true, received_tx_report.beam_1000ms);
+  TEST_ASSERT_EQUAL(true, received_tx_report.beam_250ms);
+}