修复java.lang.IndexOutOfBoundsException: Inconsistency detected. Invalid item position 的崩溃

Author: SilenceDut

app/src/main/java/com/silencedut/diffadapterdemo/ImageHolder.kt

@@ -26,7 +26,7 @@ class ImageHolder( itemView: View, recyclerAdapter: DiffAdapter): BaseDiffViewHo
     }
 
     override fun updateItem(data: ImageData, position: Int) {
-        Log.d(TAG,"updateItem : "+context.resources.getResourceName(data.sourceId))
+        Log.d(TAG,"updatePartWithPayload : "+context.resources.getResourceName(data.sourceId))
 
 
         imageView?.setImageResource(data.sourceId)

app/src/main/java/com/silencedut/diffadapterdemo/MainActivity.java

@@ -36,30 +36,30 @@ protected void onCreate(Bundle savedInstanceState) {
         mRVTest.setLayoutManager(linearLayoutManager);
         mRVTest.setAdapter(mDiffAdapter);
         scheduleUpdate();
-        mRVTest.postDelayed(new Runnable() {
-            @Override
-            public void run() {
-                scheduleUpdate();
-                mRVTest.postDelayed(this,1000);
-
-            }
-        },1000);
-
-        mRVTest.postDelayed(new Runnable() {
-            @Override
-            public void run() {
-
-                List<Long> uids = TestCode.Companion.getQueueUids();
-
-                for(int index =0 ;index <uids.size() ;index ++ ) {
-                    ModelProvider.getModel(MainActivity.this,DataChangeViewModel.class).getChangedTextSource().setValue(new DataSource(uids.get(index),R.drawable.ic_launcher_foreground,"ddd"));
-                }
-
-
-                mRVTest.postDelayed(this,800);
-
-            }
-        },800);
+////        mRVTest.postDelayed(new Runnable() {
+////            @Override
+////            public void run() {
+////                scheduleUpdate();
+////                mRVTest.postDelayed(this,1000);
+////
+////            }
+////        },1000);
+//
+//        mRVTest.postDelayed(new Runnable() {
+//            @Override
+//            public void run() {
+//
+//                List<Long> uids = TestCode.Companion.getQueueUids();
+//
+//                for(int index =0 ;index <uids.size() ;index ++ ) {
+//                    ModelProvider.getModel(MainActivity.this,DataChangeViewModel.class).getChangedTextSource().setValue(new DataSource(uids.get(index),R.drawable.ic_launcher_foreground,"ddd"));
+//                }
+//
+//
+//                mRVTest.postDelayed(this,800);
+//
+//            }
+//        },800);
 
 
 

app/src/main/java/com/silencedut/diffadapterdemo/TextHolder.kt

@@ -28,14 +28,14 @@ class TextHolder(itemViewRoot: View, recyclerAdapter: DiffAdapter): BaseDiffView
     }
 
     override fun updateItem(data: TextData, position: Int) {
-        Log.d(TAG,"updateItem")
+        Log.d(TAG,"updatePartWithPayload")
         textView?.text = data.content
         textView?.setBackgroundColor(data.backgroundColor)
     }
 
-    override fun updateItem(data: TextData, position: Int, payload: Bundle) {
+    override fun updatePartWithPayload(position: Int, payload: Bundle) {
 
-        Log.d(TAG,"position :"+position+"updateItem payload content :"+payload.getString("content")+",backgroundColor : "+payload.getString("backgroundColor"))
+        Log.d(TAG,"position :"+position+"updatePartWithPayload payload content :"+payload.getString("content")+",backgroundColor : "+payload.getString("backgroundColor"))
         if(payload.getString("content")!=null) {
             textView?.text = payload.getString("content")
         }

diffadapter/src/main/java/com/silencedut/diffadapter/DiffAdapter.java

@@ -187,7 +187,8 @@ public <T extends BaseMutableData> void addData(T data) {
             return;
         }
         mDatas.add(data);
-        doNotifyUI();
+        mDifferHelper.updateInnerList(mDatas);
+        notifyItemChanged(mDatas.size()-1);
     }
 
 
@@ -200,7 +201,8 @@ public <T extends BaseMutableData> void addData(List<T> datas) {
             return;
         }
         mDatas.addAll(datas);
-        doNotifyUI();
+        mDifferHelper.updateInnerList(mDatas);
+        notifyItemChanged(mDatas.size() - datas.size(),datas.size());
     }
 
 
@@ -229,7 +231,6 @@ public void updateData(BaseMutableData newData) {
 
             }
         }
-        doNotifyUI();
 
     }
 
@@ -239,14 +240,17 @@ public void deleteData(BaseMutableData data) {
         }
         Iterator<BaseMutableData> iterator = mDatas.iterator();
 
+        int position = -1;
         while (iterator.hasNext()) {
+            position ++;
 
             if(data.uniqueItemFeature().equals(iterator.next().uniqueItemFeature())) {
                 iterator.remove();
+                mDifferHelper.updateInnerList(mDatas);
+                notifyItemRemoved(position);
                 break;
             }
         }
-        doNotifyUI();
 
     }
 
@@ -303,7 +307,7 @@ public void onBindViewHolder(@NonNull BaseDiffViewHolder baseDiffViewHolder, int
         try {
             baseDiffViewHolder.updateItem(mDifferHelper.getCurrentList().get(position), position);
         }catch (Exception e) {
-            Log.e(TAG,"onBindViewHolder updateItem error",e);
+            Log.e(TAG,"onBindViewHolder updatePartWithPayload error",e);
         }
     }
 
@@ -323,9 +327,9 @@ public void onBindViewHolder(@NonNull BaseDiffViewHolder holder, int position, @
             this.onBindViewHolder(holder,position);
         }else  {
             try {
-                holder.updateItem(mDifferHelper.getCurrentList().get(position), position,(Bundle) payloads.get(0));
+                holder.updatePartWithPayload(position,(Bundle) payloads.get(0));
             }catch (Exception e) {
-                Log.e(TAG,"onBindViewHolder updateItem payload error",e);
+                Log.e(TAG,"onBindViewHolder updatePartWithPayload payload error",e);
             }
         }
 

diffadapter/src/main/java/com/silencedut/diffadapter/holder/BaseDiffViewHolder.java

@@ -51,11 +51,19 @@ public BaseDiffViewHolder(View itemView, DiffAdapter baseRecyclerAdapter) {
         setUIContext(mBaseAdapter.mContext);
     }
 
-
+    /**
+     * default update item way , which payload is empty
+     * @param data
+     * @param position
+     */
     public abstract void updateItem(@NonNull T data, int position);
 
-    public void updateItem(@NonNull T data, int position, @NonNull Bundle payload){
-        this.updateItem(data,position);
+    /**
+     * if payload is not empty  , this method will be call rather than {@link #updateItem(T, int)}
+     * @param position
+     */
+    public void updatePartWithPayload(int position, @NonNull Bundle payload){
+
     }
 
 

diffadapter/src/main/java/com/silencedut/diffadapter/holder/NoDataDifferHolder.java

@@ -1,5 +1,6 @@
 package com.silencedut.diffadapter.holder;
 
+import android.support.annotation.NonNull;
 import android.view.View;
 
 import com.silencedut.diffadapter.DiffAdapter;
@@ -16,7 +17,7 @@ public NoDataDifferHolder(View itemView, DiffAdapter baseRecyclerAdapter) {
     }
 
     @Override
-    public void updateItem(BaseMutableData data, int position) {
+    public void updateItem(@NonNull BaseMutableData data, int position) {
 
     }
 

diffadapter/src/main/java/com/silencedut/diffadapter/utils/AsyncListUpdateDiffer.java

@@ -130,8 +130,7 @@ public void run() {
     }
 
     private void latchList(@NonNull List<T> newList, @NonNull DiffUtil.DiffResult diffResult) {
-        this.mList = newList;
-        this.mReadOnlyList = Collections.unmodifiableList(newList);
+        updateInnerList(newList);
         diffResult.dispatchUpdatesTo(this.mUpdateCallback);
     }
 
@@ -145,6 +144,12 @@ public void updateSingleItem(int changedPosition, Bundle payload) {
 
     }
 
+    public void updateInnerList(@NonNull List<T> newList){
+        ++this.mMaxScheduledGeneration;
+        this.mList = newList;
+        this.mReadOnlyList = Collections.unmodifiableList(newList);
+    }
+
 
     private static class MainThreadExecutor implements Executor {
         final Handler mHandler = new Handler(Looper.getMainLooper());