Skip to content

Commit 1d8781e

Browse files
authored
Update failing tests (#92)
* Update to using factories * Update typesense version * Update typesense version
1 parent 36002f0 commit 1d8781e

File tree

3 files changed

+12
-27
lines changed

3 files changed

+12
-27
lines changed

.github/workflows/build.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ name: "build"
44
on: # yamllint disable-line rule:truthy
55
pull_request:
66
push:
7-
branches: main
7+
branches: [main]
88

99
jobs:
1010
build:
@@ -54,7 +54,7 @@ jobs:
5454
- name: Setup TypeSense
5555
uses: jirevwe/[email protected]
5656
with:
57-
typesense-version: 0.26.0
57+
typesense-version: '27.0'
5858
typesense-api-key: sample_key
5959

6060
- name: Run tests

tests/test_typesense_model_mixin.py

+5-13
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,17 @@
1-
from datetime import date, timedelta
2-
31
from django.test import TestCase
42

53
from django_typesense.mixins import TypesenseManager
64

7-
from tests.models import Artist, Genre, Song
5+
from tests.factories import ArtistFactory, GenreFactory, SongFactory
6+
from tests.models import Song
87
from tests.utils import get_document
98

109

1110
class TestTypeSenseMixin(TestCase):
1211
def setUp(self):
13-
self.artist = Artist.objects.create(name="artist1")
14-
self.genre = Genre.objects.create(name="genre1")
15-
self.song = Song.objects.create(
16-
title="New Song",
17-
genre=self.genre,
18-
release_date=date.today(),
19-
description="New song description",
20-
duration=timedelta(minutes=3, seconds=35),
21-
)
22-
self.song.artists.add(self.artist.pk)
12+
self.genre = GenreFactory()
13+
self.artist = ArtistFactory()
14+
self.song = SongFactory(genre=self.genre, artists=[self.artist])
2315

2416
def test_get_collection_class(self):
2517
collection_class = Song.get_collection_class()

tests/test_typesense_signals.py

+5-12
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,15 @@
1-
from datetime import date, timedelta
2-
31
from django.test import TestCase
42

5-
from tests.models import Artist, Genre, Library, Song
3+
from tests.factories import ArtistFactory, GenreFactory, SongFactory
4+
from tests.models import Artist, Library, Song
65
from tests.utils import get_document
76

87

98
class TestTypeSenseSignals(TestCase):
109
def setUp(self):
11-
self.genre = Genre.objects.create(name="genre1")
12-
self.artist = Artist.objects.create(name="artist1")
13-
self.song = Song.objects.create(
14-
title="New Song",
15-
genre=self.genre,
16-
release_date=date.today(),
17-
description="New song description",
18-
duration=timedelta(minutes=3, seconds=35),
19-
)
10+
self.genre = GenreFactory()
11+
self.artist = ArtistFactory()
12+
self.song = SongFactory(genre=self.genre)
2013

2114
def test_post_save_typesense_models(self):
2215
schema_name = self.song.collection_class.schema_name

0 commit comments

Comments
 (0)