From afb78fcee193d5b36d4193954623173bdac751eb Mon Sep 17 00:00:00 2001 From: Jakub Dubec Date: Wed, 1 Jan 2020 21:15:58 +0100 Subject: [PATCH] =?UTF-8?q?If=20there=20is=20no=20valid=20value=20in=20lis?= =?UTF-8?q?t=20fields,=20return=20empty=20list=20=F0=9F=8D=BA?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.md | 5 +++++ django_request_formatter/__version__.py | 1 - django_request_formatter/fields.py | 10 ++++++++-- django_request_formatter/version.py | 1 + setup.py | 2 +- 5 files changed, 15 insertions(+), 4 deletions(-) delete mode 100644 django_request_formatter/__version__.py create mode 100644 django_request_formatter/version.py diff --git a/CHANGELOG.md b/CHANGELOG.md index e0a7ba9..01b7e9c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## 0.5.6 : 01.01.2020 + +- **Fix**: Fixing issue from version `0.5.5` but this time for real +- **Change**: Renamed version file from `__version__.py` to `version.py` + ## 0.5.5 : 01.01.2020 - **Fix**: Check instance only if there is a value in `FieldList` and `FormFieldList` diff --git a/django_request_formatter/__version__.py b/django_request_formatter/__version__.py deleted file mode 100644 index 31d29d8..0000000 --- a/django_request_formatter/__version__.py +++ /dev/null @@ -1 +0,0 @@ -__version__ = '0.5.5' diff --git a/django_request_formatter/fields.py b/django_request_formatter/fields.py index aaa378d..b962766 100644 --- a/django_request_formatter/fields.py +++ b/django_request_formatter/fields.py @@ -24,7 +24,10 @@ def __init__(self, field, **kwargs): super().__init__(**kwargs) def to_python(self, value) -> typing.List: - if value and not isinstance(value, list): + if not value: + return [] + + if not isinstance(value, list): raise ValidationError(self.error_messages['not_list'], code='not_list') result = [] @@ -74,7 +77,10 @@ class FormFieldList(FormField): } def to_python(self, value): - if value and not isinstance(value, list): + if not value: + return [] + + if not isinstance(value, list): raise ValidationError(self.error_messages['not_list'], code='not_list') result = [] diff --git a/django_request_formatter/version.py b/django_request_formatter/version.py new file mode 100644 index 0000000..8701e4d --- /dev/null +++ b/django_request_formatter/version.py @@ -0,0 +1 @@ +__version__ = '0.5.6' diff --git a/setup.py b/setup.py index f89c27b..412d879 100644 --- a/setup.py +++ b/setup.py @@ -18,7 +18,7 @@ def read_files(files): meta = {} -with open('./django_request_formatter/__version__.py') as f: +with open('./django_request_formatter/version.py') as f: exec(f.read(), meta) setup(