Skip to content

Add post-deploy message for extensions migration to Dev Dash #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jul 14, 2025

WHY are these changes introduced?

To improve the developer experience when migrating extensions to the Developer Dashboard by providing clear next steps after deployment.

WHAT is this pull request doing?

This PR enhances the deploy process to detect when extensions are being migrated to the Developer Dashboard and provides guidance to developers on next steps. Specifically:

  1. Displays a "Next steps" section in the success message when extensions are migrated

Captura de pantalla 2025-07-14 a las 17.16.46.png

How to test your changes?

  1. Deploy an app with extensions that haven't been migrated to the Developer Dashboard
    1b. You can force this locally by removing the user_identifier from some extensions in your DB
  2. Verify that the success message includes the "Next steps" section with instructions
  3. Deploy an app with extensions that have already been migrated
  4. Verify that the standard success message appears without the migration guidance

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Jul 14, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.26% (+0.07% 🔼)
13050/16676
🟡 Branches
72.44% (+0.1% 🔼)
6354/8771
🟡 Functions
78.18% (+0.02% 🔼)
3376/4318
🟡 Lines
78.67% (+0.08% 🔼)
12358/15708
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / loader.ts
93.36% (-0.09% 🔻)
85.78% (-0.27% 🔻)
97.22% (-0.08% 🔻)
94.37% (-0.06% 🔻)
🟡
... / context.ts
75.47% (+0.22% 🔼)
61.82% (+2.99% 🔼)
73.91% (-3.36% 🔻)
77.89% (+0.97% 🔼)
🟢
... / patch-app-configuration-file.ts
100% (+6.67% 🔼)
80% (-20% 🔻)
100% (+14.29% 🔼)
100% (+6.67% 🔼)

Test suite run success

3038 tests passing in 1318 suites.

Report generated by 🧪jest coverage report action from 4030098

@isaacroldan isaacroldan marked this pull request as ready for review July 14, 2025 15:17
@isaacroldan isaacroldan requested a review from a team as a code owner July 14, 2025 15:17
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@isaacroldan isaacroldan changed the title show custom message when deploying after migration Add post-deploy message for extensions migration to Dev Dash Jul 14, 2025
@isaacroldan isaacroldan force-pushed the 07-14-show_custom_message_when_deploying_after_migration branch from af3ef9a to 4030098 Compare July 16, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant