Skip to content

Commit df53398

Browse files
committed
Tighten SECRET_PATTERNS comment per review
Assisted-By: devx/044e1f3f-fe03-4f4c-8aa7-520114eab4a0
1 parent f1daa19 commit df53398

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

‎packages/app/src/cli/services/app-security-engine/rules/secret-rules.ts‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,13 @@ interface SecretPattern {
2626

2727
export const SECRET_PATTERNS: SecretPattern[] = [
2828
// Shopify credentials are recognized by value prefix, never by variable or
29-
// key name. A secret-sounding name proves nothing — `.env.example` files
30-
// legitimately assign placeholders to `SHOPIFY_API_SECRET`, and scoring
31-
// those is how this check missed its own static-tier bar (provable facts,
32-
// near-zero FPs). shpat_/shpca_/shppa_/shpss_ bodies are 32-char hex;
33-
// shprt_/shpsb_/shptka_/shpua_ are alphanumeric. The first seven prefixes
34-
// are already public via shopify.dev docs and published secret-scanning
35-
// rules (gitleaks, GitHub partner patterns); shpua_ marks tokens issued
36-
// while an app is still in development — the most likely to be committed.
29+
// key name — a secret-sounding name with a placeholder value (as in
30+
// committed `.env.example` files) is not evidence of a leak.
31+
// shpat_/shpca_/shppa_/shpss_ bodies are hex; shprt_/shpsb_/shptka_/shpua_
32+
// are alphanumeric. The first seven prefixes are already public via
33+
// shopify.dev docs and published secret-scanning rules (gitleaks, GitHub
34+
// partner patterns); shpua_ marks tokens issued while an app is still in
35+
// development — the most likely to be committed.
3736
{
3837
regex: /shp(?:(?:at|ca|pa|ss)_[a-fA-F0-9]{16,}|(?:rt|sb|tka|ua)_[a-zA-Z0-9]{16,})/,
3938
name: 'Shopify token',

0 commit comments

Comments
 (0)