Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-align alert icon in yellow alerts banner #1244

Open
richardxia opened this issue Mar 16, 2023 · 0 comments
Open

Top-align alert icon in yellow alerts banner #1244

richardxia opened this issue Mar 16, 2023 · 0 comments
Assignees

Comments

@richardxia
Copy link
Member

While our designers were looking at #1241, they noticed that the alert icon (the exclamation point inside a circle) is middle-aligned, but middle alignment looks kind of bad on mobile, especially if the text is large.

They're suggesting that we top-align the icon, as shown in #1241. Also, in a video chat, we specifically said that it would be ideal to align the point in the exclamation point to the baseline of the first line of text. The baseline is the line that most letters sit on, not including descenders such as the tails in j, p, and q. That might be tricky from a CSS perspective, but at least changing it to a top alignment would be better than the current middle alignment.

Here's a pretty thorough article on vertical alignment in CSS, in case it is useful for understanding how baseline alignment works: https://christopheraue.net/design/vertical-align

Current, middle alignment

Screen Shot 2023-03-15 at 6 34 39 PM

Requested change in this ticket, baseline alignment

Screen Shot 2023-03-15 at 6 35 28 PM

@candywang candywang self-assigned this Mar 24, 2023
@richardxia richardxia assigned davidagustin and unassigned candywang Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants