Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling with error codes #4

Closed
rianadutta opened this issue Aug 19, 2022 · 5 comments
Closed

error handling with error codes #4

rianadutta opened this issue Aug 19, 2022 · 5 comments
Assignees

Comments

@rianadutta
Copy link
Contributor

rianadutta commented Aug 19, 2022

for wrong usage and no output

@rianadutta rianadutta self-assigned this Sep 9, 2022
@rianadutta
Copy link
Contributor Author

I had pushed changes for this issue last week onto testset.py and testdiff.py so it should be good to be closed @jeffbl

@jeffbl
Copy link
Member

jeffbl commented Jan 26, 2023

Much improved, since there are error codes for different cases. Thanks! I won't insist, but for future, best practices might include:

  1. documenting the errors, or using constants to describe them
  2. Having an error exit function so that if the same error can be triggered from multiple places, the string only exists in one place for that error.
  3. following standards like POSIX error codes which have existing meanings for some codes (hat tip juliette for this link.)

I'll leave the priority on these up to you, or if this should be left open / any new issues should be created in current sprints.

@rianadutta
Copy link
Contributor Author

@jeffbl this could be moved into backlog then I think?

@rianadutta
Copy link
Contributor Author

Have created a new issue to address the tasks you addressed above, so I'm closing this.

@jeffbl
Copy link
Member

jeffbl commented Feb 20, 2023

For future reference: improvements are broken out into #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants