-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create standard way for preprocessors to do graphic resizing #867
Comments
Putting in current sprint to at least decide what to do, even if implementation is later. @AndyBaiMQC please don't spend time on resizing now, so that we can decide on an overall plan. |
Hmm...if we really want to have image resizing as a shared feature I think the most convenient options would be to build it into the orchestrator or have all the preprocessors just use pillow. My immediate reaction to including it in the orchestrator is hesitancy, since we want to keep it small to avoid bugs, but we could probably use something like sharp in cases where 1) a Is resizing/reencoding the only tasks that would be necessary, @AndyBaiMQC? |
Reassigning to @AndyBaiMQC and @jaydeepsingh25 since we're taking the common library route. |
Moving to backlog until there is space in a sprint for this. |
@jeffbl Circling back to this one: Need a comprehensive review on list of models/methods for existing preprocessors, and the changes following Ollama adoption (which hopefully makes it easier to do 'one size fits as many as possible') |
Talking with @AndyBaiMQC this morning, it will likely be necessary to resize graphics going to local ML models, each of which may have its own constraints. We've been burned by resizing issues numerous times throughout the project (example example , and there are others). Goal of this work item is to come up with a clear and documented way for preprocessors to resize graphics. Key functionality includes:
Assigning to @JRegimbal first to weigh in on architecture, before going to @jaydeepsingh25 for implementation. Some options:
BONUS: If we centralize this, we could also use it to transform photos into a common format, to support a wider variety of weird graphic types. E.g., if the library can transform .png into .jpg as well, then we don't have to rely on preprocessors supporting .png. Probably should break out into separate issue, or generalize this one into "transform graphics before they go to preprocessors)
The text was updated successfully, but these errors were encountered: