Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Homebrew cask for macOS -- would you like to review before submission? #255

Closed
davay opened this issue Dec 29, 2024 · 2 comments
Closed

Comments

@davay
Copy link

davay commented Dec 29, 2024

First, apologies if this is not the right place to discuss this, especially since it didn't fit any of the templates.

So I've just created a Homebrew cask to install Serial-Studio on MacOS that:

  • Works on both Intel and Apple Silicon Macs
  • Should stay in sync with new GitHub releases, provided the naming scheme doesn't change

Commit: Homebrew/homebrew-cask@109a879

I think it's ready for submission, but I thought I should at least notify you as the creator first.

To test this I've done:

  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source serial-studio: test installation (on apple silicon only though)
  • brew audit --new serial-studio: per requirements
  • brew style --fix serial-studio.rb: best practices
  • brew livecheck serial-studio --debug: test auto-update
  • Checked existing casks/PRs (just to see if somebody's already/currently making one)

Technically Homebrew is supported on Linux too, but I feel people prefer other native repos anyway, let me know if you'd like me to add that too or if this is good to go.

Thanks 🙂

@alex-spataru
Copy link
Member

Hi @davay,

First of all, thank you so much for the work you've done! I use Homebrew a lot, but I never found the time to register my projects with it, so I really appreciate you stepping in to do that. The current code looks great—thanks again!

Regarding Linux, I’ve never used Homebrew on it either. Like you mentioned, I tend to stick with distro-specific repositories or just install the .deb/.rpm packages directly. But if you think there’s value in having it available through Homebrew on Linux, feel free to add it.

Thanks again,
Alex

@davay
Copy link
Author

davay commented Jan 10, 2025

@alex-spataru The PR is checked in!

Here's the cask: https://formulae.brew.sh/cask/serial-studio

No problem, it wasn't much, otoh I think the amount of support you provide is amazing, not really a Chinese speaker but this is the first project I've seen where there's support for another language even though you don't speak it yourself either

Best of luck! It's a great software 🙂

@davay davay closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants