-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with merging MNVs within the same codon #8
Comments
Also, one thing I would add to the script is possibility to read compressed codons files:
|
Hi Luka, Glad this has been working well for you! A difficulty with this request is that If we decide to merge by
With any of the other transcripts, the tools outputs an MNP and annotates the original records with a
We could potentially output all three records with a FILTER or INFO field describing the codon used for the record. Would that be useful? -Don |
Happy to consider compressed codon files as well. I'll see if I can test your changes soon. |
Hi @DonFreed , thanks for looking into this. I know that these scripts aren't main tools of Sentieon toolkit, but I found them very useful. I am also investigating possibility to avoid loading whole codons file to a memory as the latest transcript file crate codons file around 250 GB. I am trying to subset it on the fly to mutations of interest, will let you know if I found something which can improve runtime. I tested it on 10 mutations only and it lasted 1.5h. |
Great. Please let us know if you are able to find any runtime improvements. Do you have any thoughts on the type of output you would like to see? The current |
Actually, only idea I have that in these cases we keep filter of merged mutations to: PASS instead of MERGED. That way, user who annotates these VCFs later will have both separate mutations and MNV with their effect. I don't have any other ideas tbh. |
One solution would be to output both merged and unmerged variants as |
Hi all,
I've used this merge_mnp.py script previously with great success, but now, I encountered an issue on certain positions, I found this:
In this part of code:
This key will be overwritten, since one position contains multiple codons, and for transcript: NM_001130917 they shouldn't be merged, for all other they should be merged.
This is a subset of my VCF:
Thanks a lot for your help!
Luka
The text was updated successfully, but these errors were encountered: