Skip to content

Commit 6d410fe

Browse files
committed
Merge pull request #637 from simontabor/gosquared-auto-tag
GoSquared: remove superfluous setting of visitorName
2 parents 73effbb + 89d8daa commit 6d410fe

File tree

2 files changed

+0
-19
lines changed

2 files changed

+0
-19
lines changed

lib/gosquared/index.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -130,12 +130,6 @@ GoSquared.prototype.identify = function(identify){
130130
} else {
131131
push('properties', props);
132132
}
133-
134-
var email = identify.email();
135-
var username = identify.username();
136-
137-
var name = email || username || id;
138-
if (name) push('set', 'visitorName', name);
139133
};
140134

141135
/**

lib/gosquared/test.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -223,19 +223,6 @@ describe('GoSquared', function(){
223223
}
224224
});
225225
});
226-
227-
it('should prefer an email for visitor name', function(){
228-
analytics.identify('id', {
229-
230-
username: 'username'
231-
});
232-
analytics.called(window._gs, 'set', 'visitorName', '[email protected]');
233-
});
234-
235-
it('should also prefer a username for visitor name', function(){
236-
analytics.identify('id', { username: 'username' });
237-
analytics.called(window._gs, 'set', 'visitorName', 'username');
238-
});
239226
});
240227

241228
describe('#track', function(){

0 commit comments

Comments
 (0)