Skip to content

Commit 0ba851c

Browse files
author
Carl Thorner and Jesse House
committed
Remove stubbed ajax in implementation and add stubs for testing
1 parent 155f937 commit 0ba851c

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

lib/scratch-it/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ var ScratchIt = module.exports = integration('Scratch-it Analytics')
1616
.global('ScratchItAnalytics')
1717
.option('trkId', '')
1818
.option('url', 'http://trk.scratch-it.com/trk')
19-
.option('ajax', { get: function(){} })
2019
.tag('<script src="//static.scratch-it.com/public/scratch-it-analytics.min.js">');
2120

2221
/**
@@ -26,7 +25,7 @@ ScratchIt.prototype.initialize = function() {
2625
var self = this;
2726

2827
this.load(function(){
29-
window._ScratchIt = new window.ScratchItAnalytics(self.options.trkId, { url: self.options.url, ajax: self.options.ajax });
28+
window._ScratchIt = new window.ScratchItAnalytics(self.options.trkId, { url: self.options.url });
3029
self.ready();
3130
});
3231
};

lib/scratch-it/test.js

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,8 @@ var ScratchIt = require('./');
77
describe('ScratchIt', function() {
88
var analytics;
99
var scratchIt;
10-
var $ = {
11-
get: function(){}
12-
};
1310
var options = {
14-
trkId: 'foo',
15-
opts: {
16-
ajax: $
17-
}
11+
trkId: 'foo'
1812
};
1913

2014
beforeEach(function() {
@@ -45,12 +39,6 @@ describe('ScratchIt', function() {
4539
});
4640

4741
describe('#initialize', function() {
48-
// it('should create the window._ScratchIt object', function() {
49-
// analytics.assert(window._ScratchIt === undefined);
50-
// analytics.initialize();
51-
// analytics.assert(window._ScratchIt);
52-
// });
53-
5442
it('should call #load', function() {
5543
analytics.initialize();
5644
analytics.called(scratchIt.load);
@@ -60,12 +48,24 @@ describe('ScratchIt', function() {
6048

6149
describe('loading', function() {
6250
it('should load', function(done) {
51+
analytics.stub(window, 'Cookies');
52+
analytics.stub(window.Cookies, 'get');
53+
analytics.stub(window.Cookies, 'set');
54+
analytics.stub(window, 'uuid');
55+
analytics.stub(window.uuid, 'v4');
56+
analytics.stub(window, 'reqwest');
6357
analytics.load(scratchIt, done);
6458
});
6559
});
6660

6761
describe('after loading', function() {
6862
beforeEach(function(done) {
63+
analytics.stub(window, 'Cookies');
64+
analytics.stub(window.Cookies, 'get');
65+
analytics.stub(window.Cookies, 'set');
66+
analytics.stub(window, 'uuid');
67+
analytics.stub(window.uuid, 'v4');
68+
analytics.stub(window, 'reqwest');
6969
analytics.once('ready', done);
7070
analytics.initialize();
7171
});

0 commit comments

Comments
 (0)