Skip to content

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Oct 19, 2025

Changes:

  • Removed checkver and autoupdate

Because:

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Documentation

    • Added a top-level deprecation notice for the Windows artifact.
  • Chores

    • Removed the automatic version-checking/update metadata that pointed to the previous repository.

Added deprecation notice for Windows artifact support.
@coderabbitai
Copy link

coderabbitai bot commented Oct 19, 2025

Walkthrough

Added a top-level ## deprecation notice to bucket/fbflipper.json and removed its checkver block that referenced the GitHub repository; no other manifest update logic was changed.

Changes

Cohort / File(s) Summary
Manifest edits
bucket/fbflipper.json
Inserted a top-level ## field containing a deprecation notice; removed the checkver block that referenced github: "https://github.com/facebook/flipper". No other autoupdate/version logic was changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I nibble lines of JSON light,

A gentle note, a dusk in sight,
The checkver fades, the key says "done",
A quiet hop — the change is run. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed The PR description is mostly complete and addresses the key requirements of the template. It includes a clear "Changes:" section explaining what was removed, a "Because:" section providing the reasoning with links and dates, and both required checkboxes are checked (conventional PR title format and confirmation of reading the Contributing Guide). While the description lacks an explicit issue reference in the format suggested by the template (e.g., "Relates to #16379"), this element is presented as guidance in HTML comments rather than as a strictly required section, making it a non-critical omission. The substantive content clearly communicates the intent and justification for the changes.
Title Check ✅ Passed The pull request title "[email protected]: Remove checkver" is directly and specifically related to the main changes documented in the raw summary. The summary confirms that the checkver block containing the GitHub repository reference was removed from the fbflipper manifest, which is exactly what the title describes. The title is clear, concise, and non-misleading—it avoids vague terminology and accurately conveys the primary modification to the file. While the PR objectives also mention autoupdate removal, the raw_summary's documented changes focus on the checkver removal, which the title appropriately highlights.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

fbflipper

  • Lint
  • Description
  • License
  • Hashes

Check the full log for details.

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Oct 19, 2025

Related: #16379.

@z-Fng z-Fng changed the title [email protected]: Removed checkver and autoupdate [email protected]: Remove checkver Oct 23, 2025
@z-Fng z-Fng merged commit 8812f01 into ScoopInstaller:master Oct 23, 2025
3 checks passed
@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Oct 23, 2025

Why keep autoupdate? Just curious.

@z-Fng
Copy link
Member

z-Fng commented Oct 23, 2025

IMO, if we keep the autoupdate field, users can still install a specific version via scoop install app@version. Otherwise:

PS> scoop install [email protected]
WARN  Given version (0.238.0) does not match manifest (0.239.0)
WARN  Attempting to generate manifest for 'fbflipper' (0.238.0)
'fbflipper' does not have autoupdate capability

P.S. If ScoopInstaller/Scoop#6370 gets merged, this will no longer be necessary and can be removed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants