Merge pull request #1092 from dpmm99/fix-interactive-eos

martindevans · web-flow · commit f8a7263e8772 · 2025-02-21T02:04:41.000Z
InteractiveExecutor now stops at EOS tokens again
diff --git a/LLama/LLamaInteractExecutor.cs b/LLama/LLamaInteractExecutor.cs
@@ -213,9 +213,9 @@ private Task PreprocessLlava(string text, InferStateArgs args, bool addBos = tru
                     return (true, Array.Empty<string>());
             }
 
-            if (_embeds.Count > 0 && _embeds.Last() == Context.Vocab.EOS)
+            if (_embeds.Count > 0 && _embeds.Last().IsEndOfGeneration(Context.Vocab))
             {
-                return (true, new[] { " [end of text]\n" });
+                return (true, Array.Empty<string>());
             }
 
             if (args.RemainedTokens <= 0 && inferenceParams.MaxTokens != -1)

Original file line number	Diff line number	Diff line change
`@@ -213,9 +213,9 @@ private Task PreprocessLlava(string text, InferStateArgs args, bool addBos = tru`
`213`	`213`	`return (true, Array.Empty<string>());`
`214`	`214`	`}`
`215`	`215`
`216`		`- if (_embeds.Count > 0 && _embeds.Last() == Context.Vocab.EOS)`
	`216`	`+ if (_embeds.Count > 0 && _embeds.Last().IsEndOfGeneration(Context.Vocab))`
`217`	`217`	`{`
`218`		`- return (true, new[] { " [end of text]\n" });`
	`218`	`+ return (true, Array.Empty<string>());`
`219`	`219`	`}`
`220`	`220`
`221`	`221`	`if (args.RemainedTokens <= 0 && inferenceParams.MaxTokens != -1)`